You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alejandro Abdelnur <tu...@cloudera.com> on 2012/05/10 00:32:20 UTC
Review Request: OOZIE-831 POMs cleanup/fixing of hadoop version and to be
able to publish oozie JARs to maven repo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5082/
-----------------------------------------------------------
Review request for oozie, Mohammad Islam and Virag Kothari.
Summary
-------
Adding Apache Maven repo URLs to distribution management, both for snapshots and releases
Keeping 2 hadoop versions hadooplibs, hadoop-1 (using hadoop 1.0.1) and hadoop-2 (using hadoop 2.0.0-SNAPSHOT)
Changing the version scheme of hadooplibs to be tied to Oozie release (and to be snapshots/releases based on Oozie version)
This addresses bug OOZIE-831.
https://issues.apache.org/jira/browse/OOZIE-831
Diffs
-----
trunk/hadooplibs/hadoop-0_23_1/pom.xml 1336431
trunk/hadooplibs/hadoop-0_23_2/pom.xml 1336431
trunk/hadooplibs/hadoop-0_24_0/pom.xml 1336431
trunk/hadooplibs/hadoop-1/pom.xml PRE-CREATION
trunk/hadooplibs/hadoop-1_0_1/pom.xml 1336431
trunk/hadooplibs/hadoop-2/pom.xml PRE-CREATION
trunk/hadooplibs/hadoop-test-0_23_1/pom.xml 1336431
trunk/hadooplibs/hadoop-test-0_23_2/pom.xml 1336431
trunk/hadooplibs/hadoop-test-0_24_0/pom.xml 1336431
trunk/hadooplibs/hadoop-test-1/pom.xml PRE-CREATION
trunk/hadooplibs/hadoop-test-1_0_1/pom.xml 1336431
trunk/hadooplibs/hadoop-test-2/pom.xml PRE-CREATION
trunk/hadooplibs/pom.xml 1336431
trunk/pom.xml 1336431
trunk/src/main/assemblies/hadooplibs.xml 1336431
Diff: https://reviews.apache.org/r/5082/diff
Testing
-------
clean build and run some test for sanity check.
deployed to an local repo and verified all artifacts make it there.
Thanks,
Alejandro
Re: Review Request: OOZIE-831 POMs cleanup/fixing of hadoop version and to
be able to publish oozie JARs to maven repo
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
> On 2012-05-09 22:53:54, Mona Chitnis wrote:
> > trunk/pom.xml, line 48
> > <https://reviews.apache.org/r/5082/diff/1/?file=108223#file108223line48>
> >
> > why is this removed?
this is not used and creates a funny dir everytime.
PS: if you are using internally, I'd suggest to keep it in your internal repo (i'm doing that for some build tweaks I need)
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5082/#review7748
-----------------------------------------------------------
On 2012-05-09 22:32:20, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5082/
> -----------------------------------------------------------
>
> (Updated 2012-05-09 22:32:20)
>
>
> Review request for oozie, Mohammad Islam and Virag Kothari.
>
>
> Summary
> -------
>
> Adding Apache Maven repo URLs to distribution management, both for snapshots and releases
>
> Keeping 2 hadoop versions hadooplibs, hadoop-1 (using hadoop 1.0.1) and hadoop-2 (using hadoop 2.0.0-SNAPSHOT)
>
> Changing the version scheme of hadooplibs to be tied to Oozie release (and to be snapshots/releases based on Oozie version)
>
>
> This addresses bug OOZIE-831.
> https://issues.apache.org/jira/browse/OOZIE-831
>
>
> Diffs
> -----
>
> trunk/hadooplibs/hadoop-0_23_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-0_23_2/pom.xml 1336431
> trunk/hadooplibs/hadoop-0_24_0/pom.xml 1336431
> trunk/hadooplibs/hadoop-1/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-1_0_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-2/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-test-0_23_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-0_23_2/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-0_24_0/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-1/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-test-1_0_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-2/pom.xml PRE-CREATION
> trunk/hadooplibs/pom.xml 1336431
> trunk/pom.xml 1336431
> trunk/src/main/assemblies/hadooplibs.xml 1336431
>
> Diff: https://reviews.apache.org/r/5082/diff
>
>
> Testing
> -------
>
> clean build and run some test for sanity check.
>
> deployed to an local repo and verified all artifacts make it there.
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-831 POMs cleanup/fixing of hadoop version and to
be able to publish oozie JARs to maven repo
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
> On 2012-05-09 22:53:54, Mona Chitnis wrote:
> > trunk/pom.xml, line 48
> > <https://reviews.apache.org/r/5082/diff/1/?file=108223#file108223line48>
> >
> > why is this removed?
>
> Alejandro Abdelnur wrote:
> this is not used and creates a funny dir everytime.
>
>
> PS: if you are using internally, I'd suggest to keep it in your internal repo (i'm doing that for some build tweaks I need)
also note that distribution management is now pointing Apache Maven repo, so if you need an internal repo, you'll have to tweak the poms
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5082/#review7748
-----------------------------------------------------------
On 2012-05-09 22:32:20, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5082/
> -----------------------------------------------------------
>
> (Updated 2012-05-09 22:32:20)
>
>
> Review request for oozie, Mohammad Islam and Virag Kothari.
>
>
> Summary
> -------
>
> Adding Apache Maven repo URLs to distribution management, both for snapshots and releases
>
> Keeping 2 hadoop versions hadooplibs, hadoop-1 (using hadoop 1.0.1) and hadoop-2 (using hadoop 2.0.0-SNAPSHOT)
>
> Changing the version scheme of hadooplibs to be tied to Oozie release (and to be snapshots/releases based on Oozie version)
>
>
> This addresses bug OOZIE-831.
> https://issues.apache.org/jira/browse/OOZIE-831
>
>
> Diffs
> -----
>
> trunk/hadooplibs/hadoop-0_23_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-0_23_2/pom.xml 1336431
> trunk/hadooplibs/hadoop-0_24_0/pom.xml 1336431
> trunk/hadooplibs/hadoop-1/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-1_0_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-2/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-test-0_23_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-0_23_2/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-0_24_0/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-1/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-test-1_0_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-2/pom.xml PRE-CREATION
> trunk/hadooplibs/pom.xml 1336431
> trunk/pom.xml 1336431
> trunk/src/main/assemblies/hadooplibs.xml 1336431
>
> Diff: https://reviews.apache.org/r/5082/diff
>
>
> Testing
> -------
>
> clean build and run some test for sanity check.
>
> deployed to an local repo and verified all artifacts make it there.
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-831 POMs cleanup/fixing of hadoop version and to
be able to publish oozie JARs to maven repo
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5082/#review7748
-----------------------------------------------------------
trunk/pom.xml
<https://reviews.apache.org/r/5082/#comment17051>
why is this removed?
- Mona
On 2012-05-09 22:32:20, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5082/
> -----------------------------------------------------------
>
> (Updated 2012-05-09 22:32:20)
>
>
> Review request for oozie, Mohammad Islam and Virag Kothari.
>
>
> Summary
> -------
>
> Adding Apache Maven repo URLs to distribution management, both for snapshots and releases
>
> Keeping 2 hadoop versions hadooplibs, hadoop-1 (using hadoop 1.0.1) and hadoop-2 (using hadoop 2.0.0-SNAPSHOT)
>
> Changing the version scheme of hadooplibs to be tied to Oozie release (and to be snapshots/releases based on Oozie version)
>
>
> This addresses bug OOZIE-831.
> https://issues.apache.org/jira/browse/OOZIE-831
>
>
> Diffs
> -----
>
> trunk/hadooplibs/hadoop-0_23_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-0_23_2/pom.xml 1336431
> trunk/hadooplibs/hadoop-0_24_0/pom.xml 1336431
> trunk/hadooplibs/hadoop-1/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-1_0_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-2/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-test-0_23_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-0_23_2/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-0_24_0/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-1/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-test-1_0_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-2/pom.xml PRE-CREATION
> trunk/hadooplibs/pom.xml 1336431
> trunk/pom.xml 1336431
> trunk/src/main/assemblies/hadooplibs.xml 1336431
>
> Diff: https://reviews.apache.org/r/5082/diff
>
>
> Testing
> -------
>
> clean build and run some test for sanity check.
>
> deployed to an local repo and verified all artifacts make it there.
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-831 POMs cleanup/fixing of hadoop version and to
be able to publish oozie JARs to maven repo
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5082/#review7797
-----------------------------------------------------------
Ship it!
+1
- Mohammad
On 2012-05-09 22:32:20, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5082/
> -----------------------------------------------------------
>
> (Updated 2012-05-09 22:32:20)
>
>
> Review request for oozie, Mohammad Islam and Virag Kothari.
>
>
> Summary
> -------
>
> Adding Apache Maven repo URLs to distribution management, both for snapshots and releases
>
> Keeping 2 hadoop versions hadooplibs, hadoop-1 (using hadoop 1.0.1) and hadoop-2 (using hadoop 2.0.0-SNAPSHOT)
>
> Changing the version scheme of hadooplibs to be tied to Oozie release (and to be snapshots/releases based on Oozie version)
>
>
> This addresses bug OOZIE-831.
> https://issues.apache.org/jira/browse/OOZIE-831
>
>
> Diffs
> -----
>
> trunk/hadooplibs/hadoop-0_23_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-0_23_2/pom.xml 1336431
> trunk/hadooplibs/hadoop-0_24_0/pom.xml 1336431
> trunk/hadooplibs/hadoop-1/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-1_0_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-2/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-test-0_23_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-0_23_2/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-0_24_0/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-1/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-test-1_0_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-2/pom.xml PRE-CREATION
> trunk/hadooplibs/pom.xml 1336431
> trunk/pom.xml 1336431
> trunk/src/main/assemblies/hadooplibs.xml 1336431
>
> Diff: https://reviews.apache.org/r/5082/diff
>
>
> Testing
> -------
>
> clean build and run some test for sanity check.
>
> deployed to an local repo and verified all artifacts make it there.
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-831 POMs cleanup/fixing of hadoop version and to
be able to publish oozie JARs to maven repo
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5082/#review7791
-----------------------------------------------------------
for trunk. it looks perfect.
For 3.2, can we only change the minimum?
trunk/pom.xml
<https://reviews.apache.org/r/5082/#comment17099>
We tested with 0.23.1. The code is deployed into sandbox, do we need to change it for 3.2? or we can do this for trunk.
- Mohammad
On 2012-05-09 22:32:20, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5082/
> -----------------------------------------------------------
>
> (Updated 2012-05-09 22:32:20)
>
>
> Review request for oozie, Mohammad Islam and Virag Kothari.
>
>
> Summary
> -------
>
> Adding Apache Maven repo URLs to distribution management, both for snapshots and releases
>
> Keeping 2 hadoop versions hadooplibs, hadoop-1 (using hadoop 1.0.1) and hadoop-2 (using hadoop 2.0.0-SNAPSHOT)
>
> Changing the version scheme of hadooplibs to be tied to Oozie release (and to be snapshots/releases based on Oozie version)
>
>
> This addresses bug OOZIE-831.
> https://issues.apache.org/jira/browse/OOZIE-831
>
>
> Diffs
> -----
>
> trunk/hadooplibs/hadoop-0_23_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-0_23_2/pom.xml 1336431
> trunk/hadooplibs/hadoop-0_24_0/pom.xml 1336431
> trunk/hadooplibs/hadoop-1/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-1_0_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-2/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-test-0_23_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-0_23_2/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-0_24_0/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-1/pom.xml PRE-CREATION
> trunk/hadooplibs/hadoop-test-1_0_1/pom.xml 1336431
> trunk/hadooplibs/hadoop-test-2/pom.xml PRE-CREATION
> trunk/hadooplibs/pom.xml 1336431
> trunk/pom.xml 1336431
> trunk/src/main/assemblies/hadooplibs.xml 1336431
>
> Diff: https://reviews.apache.org/r/5082/diff
>
>
> Testing
> -------
>
> clean build and run some test for sanity check.
>
> deployed to an local repo and verified all artifacts make it there.
>
>
> Thanks,
>
> Alejandro
>
>