You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by GitBox <gi...@apache.org> on 2017/12/16 04:12:00 UTC

[GitHub] wu-sheng closed pull request #686: Style check header file value change.

wu-sheng closed pull request #686: Style check header file value change.
URL: https://github.com/apache/incubator-skywalking/pull/686
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/checkStyle.xml b/checkStyle.xml
index ef0f397bd..b90ee7c02 100644
--- a/checkStyle.xml
+++ b/checkStyle.xml
@@ -30,7 +30,7 @@
 
     <!-- header -->
     <module name="Header">
-        <property name="headerFile" value="${checkstyle.header.file}"/>
+        <property name="headerFile" value="CHECKSTYLE_HEAD"/>
     </module>
 
     <module name="RegexpSingleline">
diff --git a/pom.xml b/pom.xml
index 5a3e2a525..8f8d3a094 100644
--- a/pom.xml
+++ b/pom.xml
@@ -79,7 +79,6 @@
         <scala.compiler.version>2.11.7</scala.compiler.version>
         <powermock.version>1.6.4</powermock.version>
         <docker.plugin.version>0.4.13</docker.plugin.version>
-        <checkstyle.header.file>CHECKSTYLE_HEAD</checkstyle.header.file>
     </properties>
 
     <dependencies>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services