You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/08/03 13:07:09 UTC
Review Request 68187: Always built shared protobuf libraries.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68187/
-----------------------------------------------------------
Review request for mesos and Andrew Schwartzmeyer.
Repository: mesos
Description
-------
Always built shared protobuf libraries.
Diffs
-----
3rdparty/CMakeLists.txt 8300088aaec5afd5ea92268757235d8561cda916
Diff: https://reviews.apache.org/r/68187/diff/1/
Testing
-------
`ninja tests`
Thanks,
Benjamin Bannier
Re: Review Request 68187: Always built shared protobuf libraries.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68187/#review213018
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68187]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 3, 2018, 1:07 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68187/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2018, 1:07 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Always built shared protobuf libraries.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 8300088aaec5afd5ea92268757235d8561cda916
>
>
> Diff: https://reviews.apache.org/r/68187/diff/1/
>
>
> Testing
> -------
>
> `ninja tests`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68187: Always built shared protobuf libraries.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68187/#review206842
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68187']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2037/mesos-review-68187
Relevant logs:
- [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2037/mesos-review-68187/logs/stout-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\map_field.h(204): warning C4661: 'void google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::InitializeIterator(google::protobuf::MapIterator *) const': no suitable definition provided for explicit template instantiation request (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc) [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\map_field.h(204): warning C4661: 'void google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::DeleteIterator(google::protobuf::MapIterator *) const': no suitable definition provided for explicit template instantiation request (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc) [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\map_field.h(204): warning C4661: 'void google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::CopyIterator(google::protobuf::MapIterator *,const google::protobuf::MapIterator &) const': no suitable definition provided for explicit template instantiation request (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc) [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\map_field.h(204): warning C4661: 'void google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::IncreaseIterator(google::protobuf::MapIterator *) const': no suitable definition provided for explicit template instantiation request (compiling source file D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc) [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc(1449): warning C4661: 'void google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::MapBegin(google::protobuf::MapIterator *) const': no suitable definition provided for explicit template instantiation request [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc(1449): warning C4661: 'void google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::MapEnd(google::protobuf::MapIterator *) const': no suitable definition provided for explicit template instantiation request [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc(1449): warning C4661: 'bool google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::EqualIterator(const google::protobuf::MapIterator &,const google::protobuf::MapIterator &) const': no suitable definition provided for explicit template instantiation request [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc(1449): warning C4661: 'google::protobuf::Map<Key,T>::const_iterator &google::protobuf::internal::TypeDefinedMapFieldBase<Key,T>::InternalGetIterator(const google::protobuf::MapIterator *) const': no suitable definition provided for explicit template instantiation request [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc(1449): warning C4661: 'void google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::InitializeIterator(google::protobuf::MapIterator *) const': no suitable definition provided for explicit template instantiation request [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc(1449): warning C4661: 'void google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::DeleteIterator(google::protobuf::MapIterator *) const': no suitable definition provided for explicit template instantiation request [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc(1449): warning C4661: 'void google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::CopyIterator(google::protobuf::MapIterator *,const google::protobuf::MapIterator &) const': no suitable definition provided for explicit template instantiation request [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\wire_format.cc(1449): warning C4661: 'void google::protobuf::internal::TypeDefinedMapFieldBase<google::protobuf::MapKey,google::protobuf::MapValueRef>::IncreaseIterator(google::protobuf::MapIterator *) const': no suitable definition provided for explicit template instantiation request [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotobuf.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\compiler\csharp\csharp_helpers.cc(269): warning C4273: 'google::protobuf::compiler::csharp::GetEnumValueName': inconsistent dll linkage [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotoc.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
csharp_enum.obj : warning LNK4217: locally defined symbol ?GetEnumValueName@csharp@compiler@protobuf@google@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV56@0@Z (class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl google::protobuf::compiler::csharp::GetEnumValueName(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)) imported in function "public: void __cdecl google::protobuf::compiler::csharp::EnumGenerator::Generate(class google::protobuf::io::Printer *)" (?Generate@EnumGenerator@csharp@compiler@protobuf@google@@QEAAXPEAVPrinter@io@45@@Z) [D:\DCOS\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0-build\libprotoc.vcxproj] [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
(Link target) ->
protobuf_tests.obj : error LNK2001: unresolved external symbol "private: static enum google::protobuf::FieldDescriptor::CppType const * const google::protobuf::FieldDescriptor::kTypeToCppTypeMap" (?kTypeToCppTypeMap@FieldDescriptor@protobuf@google@@0QBW4CppType@123@B) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
protobuf_tests.obj : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
protobuf_tests.pb.obj : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
protobuf_tests.pb.obj : error LNK2001: unresolved external symbol "private: static __int64 google::protobuf::io::CodedOutputStream::default_serialization_deterministic_" (?default_serialization_deterministic_@CodedOutputStream@io@protobuf@google@@0_JA) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
protobuf_tests.pb.obj : error LNK2001: unresolved external symbol "private: static char const * const * const google::protobuf::FieldDescriptor::kCppTypeToName" (?kCppTypeToName@FieldDescriptor@protobuf@google@@0QBQEBDB) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
D:\DCOS\mesos\3rdparty\stout\tests\Debug\stout-tests.exe : fatal error LNK1120: 4 unresolved externals [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
269 Warning(s)
6 Error(s)
Time Elapsed 00:11:57.07
```
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2037/mesos-review-68187/logs/mesos-tests-cmake-stdout.log):
```
mesos.lib(executor.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj]
mesos.lib(health_checker.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj]
mesos.lib(http.cpp.obj) : error LNK2001: unresolved external symbol "private: static enum google::protobuf::FieldDescriptor::CppType const * const google::protobuf::FieldDescriptor::kTypeToCppTypeMap" (?kTypeToCppTypeMap@FieldDescriptor@protobuf@google@@0QBW4CppType@123@B) [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj]
mesos.lib(checker.obj) : error LNK2001: unresolved external symbol "private: static enum google::protobuf::FieldDescriptor::CppType const * const google::protobuf::FieldDescriptor::kTypeToCppTypeMap" (?kTypeToCppTypeMap@FieldDescriptor@protobuf@google@@0QBW4CppType@123@B) [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj]
mesos.lib(health_checker.obj) : error LNK2001: unresolved external symbol "private: static enum google::protobuf::FieldDescriptor::CppType const * const google::protobuf::FieldDescriptor::kTypeToCppTypeMap" (?kTypeToCppTypeMap@FieldDescriptor@protobuf@google@@0QBW4CppType@123@B) [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj]
mesos-protobufs.lib(v1.pb.obj) : error LNK2001: unresolved external symbol "private: static __int64 google::protobuf::io::CodedOutputStream::default_serialization_deterministic_" (?default_serialization_deterministic_@CodedOutputStream@io@protobuf@google@@0_JA) [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj]
mesos-protobufs.lib(v1.pb.obj) : error LNK2001: unresolved external symbol "private: static char const * const * const google::protobuf::FieldDescriptor::kCppTypeToName" (?kCppTypeToName@FieldDescriptor@protobuf@google@@0QBQEBDB) [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj]
D:\DCOS\mesos\src\mesos-default-executor.exe : fatal error LNK1120: 4 unresolved externals [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\tests\test-helper.vcxproj" (default target) (36) ->
mesos-protobufs.lib(module.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
mesos-protobufs.lib(mesos.pb.cc.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
mesos-protobufs.lib(mesos.pb.cc.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
mesos.lib(attributes.cpp.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
mesos.lib(values.cpp.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
mesos.lib(resources.cpp.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
mesos.lib(attributes.cpp.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
resources_utils.obj : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
mesos.lib(resources.cpp.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
mesos.lib(values.cpp.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
mesos.lib(resources_utils.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
D:\DCOS\mesos\src\test-helper.exe : fatal error LNK1120: 1 unresolved externals [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
172 Warning(s)
173 Error(s)
Time Elapsed 00:19:25.15
```
- Mesos Reviewbot Windows
On Aug. 3, 2018, 1:07 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68187/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2018, 1:07 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Always built shared protobuf libraries.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 8300088aaec5afd5ea92268757235d8561cda916
>
>
> Diff: https://reviews.apache.org/r/68187/diff/1/
>
>
> Testing
> -------
>
> `ninja tests`
>
>
> Thanks,
>
> Benjamin Bannier
>
>