[GitHub] [flink] twalthr commented on a change in pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #13287:
URL: https://github.com/apache/flink/pull/13287#discussion_r480160509



##########
File path: flink-core/src/main/java/org/apache/flink/api/common/CodeAnalysisMode.java
##########
@@ -19,21 +19,12 @@
 package org.apache.flink.api.common;
 
 import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.api.java.typeutils.runtime.PojoSerializer;
 
 /**
- * Specifies to which extent user-defined functions are analyzed in order
- * to give the Flink optimizer an insight of UDF internals and inform
- * the user about common implementation mistakes.
- *
- * The analyzer gives hints about:
- *  - ForwardedFields semantic properties
- *  - Warnings if static fields are modified by a Function
- *  - Warnings if a FilterFunction modifies its input objects
- *  - Warnings if a Function returns null
- *  - Warnings if a tuple access uses a wrong index
- *  - Information about the number of object creations (for manual optimization)
- *
  * @deprecated The code analysis code has been removed and this enum has no effect.
+ * <b>NOTE</b> It can not be removed from the codebase for now, because it had been serialized as part
+ * of the {@link ExecutionConfig} which in turn had been serialized as part of the {@link PojoSerializer}.

Review comment:
       Add a note when exactly we can drop this class. After dropping support for 1.8 savepoints?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org