Rel 1.2 RC2

[Richard Hirsch <hi...@gmail.com>]

I've tested Vassil's changes locally (jetty and tomcat) and they look good.

I just deployed Rel 1.2 RC 2 on stax -
http://esmecloudserverapache.dickhirsch.staxapps.net/

Please test.

D.

Re: Rel 1.2 RC2

[Richard Hirsch <hi...@gmail.com>]

display_messages_single.js is for the first page before the user has
logged-in - just a single message is displayed.

I don't think display_messages.js is currently being used.

D.

On Mon, Feb 28, 2011 at 1:48 PM, Vassil Dichev <vd...@apache.org> wrote:
> display_messages_single.js

Re: Rel 1.2 RC2

[Richard Hirsch <hi...@gmail.com>]

Yes - please create a JIRA task  for 1.3 and assign it to me.

D.

On Mon, Feb 28, 2011 at 1:58 PM, Ethan Jewett <es...@gmail.com> wrote:
> As far as I have ever been able to tell, we can just delete display_messages.js
>
> I have never really been able to tell what the files with "_top" do as
> compared to the ones without "_top". It seems to me that the ones with
> "_top" are the ones we are actually using and we could just delete the
> js and template files that don't end in "_top" where there are
> duplicates. However I've never been able to totally satisfy myself
> that this is the case, so I haven't attempted it.
>
> Is this cleanup something you'd like to put in the 1.3 queue? I think
> it is needed.
>
> Ethan
>
> On Mon, Feb 28, 2011 at 1:48 PM, Vassil Dichev <vd...@apache.org> wrote:
>> BTW I've also modified the construction of "/conversation/..." links,
>> so please also test that (even better on Tomcat).
>>
>> On a side note, I found some duplication in our JavaScript code.
>> There's display_messages.js, which seems unused, there's also
>> display_messages_top.js and display_messages_single.js, and a lot of
>> the code seems copy/pasted and modified a little. Does anyone have
>> ideas on how we could refactor those?
>>
>> Vassil
>>
>>
>> On Mon, Feb 28, 2011 at 1:51 PM, Richard Hirsch <hi...@gmail.com> wrote:
>>> I've tested Vassil's changes locally (jetty and tomcat) and they look good.
>>>
>>> I just deployed Rel 1.2 RC 2 on stax -
>>> http://esmecloudserverapache.dickhirsch.staxapps.net/
>>>
>>> Please test.
>>>
>>> D.
>>>
>>
>

Re: Rel 1.2 RC2

[Ethan Jewett <es...@gmail.com>]

As far as I have ever been able to tell, we can just delete display_messages.js

I have never really been able to tell what the files with "_top" do as
compared to the ones without "_top". It seems to me that the ones with
"_top" are the ones we are actually using and we could just delete the
js and template files that don't end in "_top" where there are
duplicates. However I've never been able to totally satisfy myself
that this is the case, so I haven't attempted it.

Is this cleanup something you'd like to put in the 1.3 queue? I think
it is needed.

Ethan

On Mon, Feb 28, 2011 at 1:48 PM, Vassil Dichev <vd...@apache.org> wrote:
> BTW I've also modified the construction of "/conversation/..." links,
> so please also test that (even better on Tomcat).
>
> On a side note, I found some duplication in our JavaScript code.
> There's display_messages.js, which seems unused, there's also
> display_messages_top.js and display_messages_single.js, and a lot of
> the code seems copy/pasted and modified a little. Does anyone have
> ideas on how we could refactor those?
>
> Vassil
>
>
> On Mon, Feb 28, 2011 at 1:51 PM, Richard Hirsch <hi...@gmail.com> wrote:
>> I've tested Vassil's changes locally (jetty and tomcat) and they look good.
>>
>> I just deployed Rel 1.2 RC 2 on stax -
>> http://esmecloudserverapache.dickhirsch.staxapps.net/
>>
>> Please test.
>>
>> D.
>>
>

Re: Rel 1.2 RC2

[Vassil Dichev <vd...@apache.org>]

BTW I've also modified the construction of "/conversation/..." links,
so please also test that (even better on Tomcat).

On a side note, I found some duplication in our JavaScript code.
There's display_messages.js, which seems unused, there's also
display_messages_top.js and display_messages_single.js, and a lot of
the code seems copy/pasted and modified a little. Does anyone have
ideas on how we could refactor those?

Vassil


On Mon, Feb 28, 2011 at 1:51 PM, Richard Hirsch <hi...@gmail.com> wrote:
> I've tested Vassil's changes locally (jetty and tomcat) and they look good.
>
> I just deployed Rel 1.2 RC 2 on stax -
> http://esmecloudserverapache.dickhirsch.staxapps.net/
>
> Please test.
>
> D.
>