You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/04/18 20:29:56 UTC

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3502: Duplicate parameter names

mitchell852 commented on a change in pull request #3502: Duplicate parameter names
URL: https://github.com/apache/trafficcontrol/pull/3502#discussion_r276822206
 
 

 ##########
 File path: traffic_portal/app/src/common/api/AuthService.js
 ##########
 @@ -17,7 +17,7 @@
  * under the License.
  */
 
-var AuthService = function($rootScope, $http, $state, $location, $q, $state, httpService, userModel, messageModel, ENV) {
+var AuthService = function($rootScope, $http, $state, $location, $q, httpService, userModel, messageModel, ENV) {
 
 Review comment:
   good catch, however, this change probably won't compile or will cause strange errors because you didn't update line 79 as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services