You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by manovotn <gi...@git.apache.org> on 2016/05/03 10:10:15 UTC

[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

GitHub user manovotn opened a pull request:

    https://github.com/apache/deltaspike/pull/49

    DELTASPIKE-1091 add default values to Weld profiles.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manovotn/deltaspike weldProfiles

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/deltaspike/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #49
    
----
commit 1482edcdc9fa7f7727b1169b74a83766c0d74b58
Author: Matej Novotny <ma...@redhat.com>
Date:   2016-05-03T08:04:53Z

    DELTASPIKE-1091 add default values to Weld profiles.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/deltaspike/pull/49


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/deltaspike/pull/49#discussion_r61874873
  
    --- Diff: deltaspike/parent/pom.xml ---
    @@ -49,7 +49,8 @@
         <properties>
             <java.version>1.6</java.version>
             <owb.version>1.2.7</owb.version>
    -        <weld.version>1.1.28.Final</weld.version>
    +        <!-- Weld profiles (in parent/code/pom.xml) override this version -->
    +        <weld.version>1.1.9.Final</weld.version>
    --- End diff --
    
    why downgrade?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

Posted by Gerhard Petracek <gp...@apache.org>.
hi @ all,

the comment in the discussion was:
we used to do it that way, but it isn't the case any longer in some areas.

regards,
gerhard



2016-05-03 15:12 GMT+02:00 manovotn <gi...@git.apache.org>:

> Github user manovotn commented on a diff in the pull request:
>
>     https://github.com/apache/deltaspike/pull/49#discussion_r61877744
>
>     --- Diff: deltaspike/parent/pom.xml ---
>     @@ -49,7 +49,8 @@
>          <properties>
>              <java.version>1.6</java.version>
>              <owb.version>1.2.7</owb.version>
>     -        <weld.version>1.1.28.Final</weld.version>
>     +        <!-- Weld profiles (in parent/code/pom.xml) override this
> version -->
>     +        <weld.version>1.1.9.Final</weld.version>
>     --- End diff --
>
>     This is based on a Gerhard's comment. He claimed that the idea is to
> list the minimal supported version. Although I strongly dislike dislike
> this approach, I put it here.
>     However if you look into Weld1 profile, you can see it is overriden by
> current version (1.1.33.Final). So this version declaration is naught but a
> mere information :)
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

Posted by manovotn <gi...@git.apache.org>.
Github user manovotn commented on a diff in the pull request:

    https://github.com/apache/deltaspike/pull/49#discussion_r61877744
  
    --- Diff: deltaspike/parent/pom.xml ---
    @@ -49,7 +49,8 @@
         <properties>
             <java.version>1.6</java.version>
             <owb.version>1.2.7</owb.version>
    -        <weld.version>1.1.28.Final</weld.version>
    +        <!-- Weld profiles (in parent/code/pom.xml) override this version -->
    +        <weld.version>1.1.9.Final</weld.version>
    --- End diff --
    
    This is based on a Gerhard's comment. He claimed that the idea is to list the minimal supported version. Although I strongly dislike dislike this approach, I put it here.
    However if you look into Weld1 profile, you can see it is overriden by current version (1.1.33.Final). So this version declaration is naught but a mere information :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/deltaspike/pull/49#discussion_r61874887
  
    --- Diff: deltaspike/parent/code/pom.xml ---
    @@ -41,7 +41,7 @@
             <wildfly.arquillian.version>1.0.2.Final</wildfly.arquillian.version>
             <glassfish3.version>3.1.2.2</glassfish3.version>
             <glassfish4.version>4.0</glassfish4.version>
    -        <wls.version>12.1</wls.version>
    +        <wls.version>12.1</wls.version>   
    --- End diff --
    
    please clean up the whitespace


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---