You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/03 18:53:42 UTC
[GitHub] [kafka] dielhennr opened a new pull request #11168: KAFKA-13160: Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft
dielhennr opened a new pull request #11168:
URL: https://github.com/apache/kafka/pull/11168
The KRaft brokers are throwing NumberFormatException when processing dynamic default broker config updates because they expect the default entity name that was used in zookeeper to be the resource name for dynamic default broker configs instead of empty string.
https://issues.apache.org/jira/browse/KAFKA-13160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #11168: KAFKA-13160: Fix BrokerMetadataPublisher to pass the correct resource name to the config handler when processing config updates
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #11168:
URL: https://github.com/apache/kafka/pull/11168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #11168: KAFKA-13160: Fix BrokerMetadataPublisher to pass the correct resource name to the config handler when processing config updates
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #11168:
URL: https://github.com/apache/kafka/pull/11168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a change in pull request #11168: KAFKA-13160: Fix BrokerMetadataPublisher to pass the correct resource name to the config handler when processing config updates
Posted by GitBox <gi...@apache.org>.
cmccabe commented on a change in pull request #11168:
URL: https://github.com/apache/kafka/pull/11168#discussion_r682803659
##########
File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala
##########
@@ -203,7 +203,15 @@ class BrokerMetadataPublisher(conf: KafkaConfig,
}
tag.foreach { t =>
val newProperties = newImage.configs().configProperties(configResource)
- dynamicConfigHandlers(t).processConfigChanges(configResource.name(), newProperties)
+ val maybeDefaultName = if (conf.usesSelfManagedQuorum) {
Review comment:
BrokerMetadataPublisher is only used when in KRaft mode, so this check is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a change in pull request #11168: KAFKA-13160: Fix BrokerMetadataPublisher to pass the correct resource name to the config handler when processing config updates
Posted by GitBox <gi...@apache.org>.
cmccabe commented on a change in pull request #11168:
URL: https://github.com/apache/kafka/pull/11168#discussion_r682803659
##########
File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala
##########
@@ -203,7 +203,15 @@ class BrokerMetadataPublisher(conf: KafkaConfig,
}
tag.foreach { t =>
val newProperties = newImage.configs().configProperties(configResource)
- dynamicConfigHandlers(t).processConfigChanges(configResource.name(), newProperties)
+ val maybeDefaultName = if (conf.usesSelfManagedQuorum) {
Review comment:
BrokerMetadataPublisher is only used when in KRaft mode, so this check is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #11168: KAFKA-13160: Fix BrokerMetadataPublisher to pass the correct resource name to the config handler when processing config updates
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #11168:
URL: https://github.com/apache/kafka/pull/11168#issuecomment-892828330
Thanks again for the PR. I left another comment.
We need some kind of test for this. The simplest way to do it is probably to add an integration test for setting dynamic configs in `KRaftClusterTest.scala`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #11168: KAFKA-13160: Fix BrokerMetadataPublisher to pass the correct resource name to the config handler when processing config updates
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #11168:
URL: https://github.com/apache/kafka/pull/11168#issuecomment-892828330
Thanks again for the PR. I left another comment.
We need some kind of test for this. The simplest way to do it is probably to add an integration test for setting dynamic configs in `KRaftClusterTest.scala`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #11168: KAFKA-13160: Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #11168:
URL: https://github.com/apache/kafka/pull/11168#issuecomment-892230644
I don't think this is the right place to make this change. BrokerMetadataPublisher should be calling `processConfigChanges` with the expected name, instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org