You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by GitBox <gi...@apache.org> on 2019/07/17 01:33:17 UTC
[GitHub] [helix] kaisun2000 opened a new pull request #339: Implementation
of stateModelDef modification in REST 2.0
kaisun2000 opened a new pull request #339: Implementation of stateModelDef modification in REST 2.0
URL: https://github.com/apache/helix/pull/339
**Issues**
My PR addresses the following Helix issues and references them in the PR title:
#338
**Description**
Current implementation of Rest 2.0 does not support stateModelDef modification. Here, we will implement
delete -- remove the stateModelDef with the input id.
put -- create new statemodeldef if no existing one with same input id
set -- replace the content of node with input id
We also add the following test cases:
Test delete model one; expect success
Test delete model one again; expect success
Create the deleted model one; expect success
Create the deleted model one again; expect failure as the same model id exists
Set the model one with modified content; expect success
Read the model one; expect the content would be same as modified content
Set the model one to original content restore original state; expect success
**Tests**
mvn test in rest directory
[INFO] Tests run: 84, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.998 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 84, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29.664 s
[INFO] Finished at: 2019-07-16T18:28:22-07:00
[INFO] ------------------------------------------------------------------------
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services