You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/02/20 04:53:31 UTC

[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1415: ORC-1375: Cancel old running ci tasks when a pr has a new commit

dongjoon-hyun commented on code in PR #1415:
URL: https://github.com/apache/orc/pull/1415#discussion_r1111453499


##########
.github/workflows/build_and_test.yml:
##########
@@ -14,6 +14,11 @@ on:
     branches:
     - main
 
+# Cancel previous PR build and test
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.event.number || github.sha }}

Review Comment:
   Is it enough to isolate `Pull Request`, @guiyanakuang ?



##########
.github/workflows/build_and_test.yml:
##########
@@ -14,6 +14,11 @@ on:
     branches:
     - main
 
+# Cancel previous PR build and test
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.event.number || github.sha }}

Review Comment:
   Is it enough to isolate `Pull Request` only, @guiyanakuang ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org