[jira] [Comment Edited] (BEAM-6116) Pushed back watermark never emitted in portable Flink runner

["Thomas Weise (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696172#comment-16696172 ] 

Thomas Weise edited comment on BEAM-6116 at 11/22/18 6:19 PM:
--------------------------------------------------------------

[~chamikara] The fix should also go to the 2.9 release branch since this is a correctness issue.

[~mxm] Since none of our tests could catch this (final watermark gets special treatment), it would be good to later add a unit test that exercises the push back scenario without final watermark (in ExecutableStageDoFnOperatorTest).


was (Author: thw):
[~chamikara] The fix should also go to the 2.9 release branch since this is a correctness issue.

[~mxm] Since none of our tests could catch this (final watermark gets special treatment), it would be good to add a unit test that exercises the push back scenario without final watermark.


> Pushed back watermark never emitted in portable Flink runner
> ------------------------------------------------------------
>
>                 Key: BEAM-6116
>                 URL: https://issues.apache.org/jira/browse/BEAM-6116
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>    Affects Versions: 2.9.0
>            Reporter: Thomas Weise
>            Assignee: Thomas Weise
>            Priority: Critical
>              Labels: portability-flink
>             Fix For: 2.9.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The portable runner pushes back the watermark while the bundle processes in the SDK worker. After the bundle is complete, that watermark needs to be emitted. That never happens, because ExecutableStageDoFnOperator does not clear the hold.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)