[GitHub] [avro] alexrosenfeld10 commented on a diff in pull request #2215: AVRO-3756: [csharp] Add a method to return types instead of writing them to disk

["alexrosenfeld10 (via GitHub)" <gi...@apache.org>]

alexrosenfeld10 commented on code in PR #2215:
URL: https://github.com/apache/avro/pull/2215#discussion_r1228476759


##########
lang/csharp/src/apache/main/CodeGen/CodeGen.cs:
##########
@@ -1136,6 +1136,48 @@
             }
         }
 
+        /// <summary>
+        /// Gets names and generated code of the schema(s) types
+        /// </summary>
+        /// <returns></returns>
+        public virtual IDictionary<string, string> GetTypes()
+        {
+            var cscp = new CSharpCodeProvider();

Review Comment:
   Sure, I can do that. My approach with OSS PRs is to match existing patterns and introduce as little deviation / other changes as possible to achieve the feature. Happy to add `using` here 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org