You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 17:08:54 UTC

[GitHub] [beam] damccorm opened a new issue, #20354: Update solution for ZetaSQL DOUBLE NaN equals checks.

damccorm opened a new issue, #20354:
URL: https://github.com/apache/beam/issues/20354

   'NaN \== NaN' for ZetaSQL DOUBLE type should be false. But it would hit into the Calcite operation simplification block to be simplified to 'null or NaN is not null' in Calcite. This would miscalculate the expression to be true.
   
   Currently, we add an additional random parameter for the wrapper function of NaN, to avoid
    triggering Calcite operation simplification. But it is only a temporary solution.
   
   Once the Calcite version updated, we should replace this method by overriding isDeterministic() for RexNode to make it false.
   
   Imported from Jira [BEAM-10550](https://issues.apache.org/jira/browse/BEAM-10550). Original Jira may contain additional context.
   Reported by: zijiesong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org