You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/13 22:23:09 UTC
[GitHub] [airflow] kaxil opened a new pull request #20863: Fix MyPy issues in AWS Sensors
kaxil opened a new pull request #20863:
URL: https://github.com/apache/airflow/pull/20863
Part of https://github.com/apache/airflow/issues/19891
Before:
```
root@12e9fcfb4678:/opt/airflow# mypy --namespace-packages airflow/providers/amazon/aws/sensors
airflow/providers/amazon/aws/sensors/s3.py:182: error: Incompatible types in assignment (expression has type "function", variable has type "Callable[..., bool]") [assignment]
check_fn: Callable[..., bool] = self.check_fn_user if self.check_fn_user is not None else self.check_fn
^
Found 1 error in 1 file (checked 33 source files)
```
After:
```
root@12e9fcfb4678:/opt/airflow# mypy --namespace-packages airflow/providers/amazon/aws/sensors
Success: no issues found in 33 source files
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #20863: Fix MyPy issues in AWS Sensors
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #20863:
URL: https://github.com/apache/airflow/pull/20863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20863: Fix MyPy issues in AWS Sensors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20863:
URL: https://github.com/apache/airflow/pull/20863#issuecomment-1012780693
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org