You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by thiagokronig <gi...@git.apache.org> on 2015/06/03 04:26:25 UTC

[GitHub] activemq-artemis pull request: ARTEMIS-129 License header should b...

GitHub user thiagokronig opened a pull request:

    https://github.com/apache/activemq-artemis/pull/11

    ARTEMIS-129 License header should be a normal comment

    To reproduce this commit, apply the following replace regex rule:
    
        search regex: /\*\*\n \* Licensed
        replace: /\*\n \* Licensed
    
    Only .java and the following files should be modified:
    
        artemis-selector/src/main/javacc/HyphenatedParser.jj
        artemis-selector/src/main/javacc/StrictParser.jj
        artemis-website/src/main/resources/styles/impact/css/pygmentize.css
        artemis-website/src/main/resources/styles/impact/css/site.css

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thiagokronig/activemq-artemis-1 artemis-129

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
    
----
commit 0efcb2e731d962061b0f1c7d6e8741b5c995caf3
Author: Thiago Kronig <th...@gmail.com>
Date:   2015-06-03T02:14:08Z

    ARTEMIS-129 License header should be a normal comment
    
    To reproduce this commit, apply a replace regex rule using:
    
        search regex: /\*\*\n \* Licensed
        replace: /\*\n \* Licensed
    
    Only .java and the following files should be modified:
    
        artemis-selector/src/main/javacc/HyphenatedParser.jj
        artemis-selector/src/main/javacc/StrictParser.jj
        artemis-website/src/main/resources/styles/impact/css/pygmentize.css
        artemis-website/src/main/resources/styles/impact/css/site.css

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-129 License header should b...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/11#issuecomment-108166705
  
    Nice one! thanks
    
    I will wait the PR build to finish first before we can merge this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-129 License header should b...

Posted by thiagokronig <gi...@git.apache.org>.

Github user thiagokronig commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/11#issuecomment-108167254
  
    Please, review it with some regexes and greps.
    
    On Tue, Jun 2, 2015 at 11:42 PM clebertsuconic <no...@github.com>
    wrote:
    
    > Nice one! thanks
    >
    > I will wait the PR build to finish first before we can merge this
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/activemq-artemis/pull/11#issuecomment-108166705>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-129 License header should b...

Posted by thiagokronig <gi...@git.apache.org>.

Github user thiagokronig commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/11#issuecomment-108447524
  
    Feel free to do so!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-129 License header should b...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-129 License header should b...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/11#issuecomment-108447089
  
    I will amend your commit with a comment:
    
    s/Only .java and the following files should be modified/These files had to be modified manually


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---