You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2023/03/02 00:20:47 UTC
[GitHub] [airflow] bbovenzi opened a new issue, #29852: Migrate fully to new graph view
bbovenzi opened a new issue, #29852:
URL: https://github.com/apache/airflow/issues/29852
Now that https://github.com/apache/airflow/pull/29413 is merged. We should get that graph to fit all user needs to and migrate to it fully, removing the legacy graph view.
Steps needed:
- [ ] Add more UI tests for new graph
- [ ] Add Filter Tasks button
- [ ] Add task state hover highlighting
- [ ] Store graph in url params
- [ ] Redirect /graph urls to new graph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NilsJPWerner commented on issue #29852: Migrate fully to new graph view
Posted by "NilsJPWerner (via GitHub)" <gi...@apache.org>.
NilsJPWerner commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1589798092
> Hey hey! Just as an FYI I am seeing some graphs that only render with the pre-2.6.0 graph and not the new 2.6.0 graph. It looks like a task group issue.
>
> Reprex:
>
> * Clone [this demo repo](https://github.com/pipeline-tools/gusty-demo-lite)
> * Follow [Running the Demo](https://github.com/pipeline-tools/gusty-demo-lite#running-the-demo) instructions to spin up Airflow.
> * Inspect `airflow_tutorial` and `gusty_tutorial` DAGs - no issues with either new or legacy graph views.
> * Inspect `more_gusty` DAG - by default the new graph shows nothing.
>
> 
>
> However, if you expand the tasks, then the graph will render:
>
> 
>
> My browser's console is giving the following errors when everything's closed:
>
> 
>
> Hope this is helpful. The new view is looking great!
I'm having the opposite issue to this. The graph doesn't show if all the task groups are expanded, but does show if I close a bunch of them. THis dag has 100s of tasks in nested task groups so maybe it is hitting some limit of the number of tasks it is able to show.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #29852: Migrate fully to new graph view
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1531901266
Also, I see you have `suffix_group_id` is that a valid field? I don't see that in the source code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #29852: Migrate fully to new graph view
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1531809474
@chriscardillo Thanks! Looks like if `prefix_group_id` isn't true we have some issues. I'll work on a fix, but for now you can edit the task config and it should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NilsJPWerner commented on issue #29852: Migrate fully to new graph view
Posted by "NilsJPWerner (via GitHub)" <gi...@apache.org>.
NilsJPWerner commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1600972250
Another piece of feedback. When you have a task selected and flip between the Graph view and Logs or Details and then back to the graph view, the graph resets. You then have to find the task again. I feel like it should keep the state of the graph when you click through different tabs or at least keep the selected task centered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi closed issue #29852: Migrate fully to new graph view
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi closed issue #29852: Migrate fully to new graph view
URL: https://github.com/apache/airflow/issues/29852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] set92 commented on issue #29852: Migrate fully to new graph view
Posted by "set92 (via GitHub)" <gi...@apache.org>.
set92 commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1520240321
Couldn't find a Slack channel of feedback, so I suppose the best option is here. I was testing the new UI in 2.6.0rc1, and wanted to note a couple of things I think the new UI doesn't do as good as the old one.
- Too plain, before I could easily see the different types of tasks by color, now is harder to locate some of them, or I have to zoom more. Also, the background is white, the boxes are white... It is hard to see what is inside a Taskgroup and what not.
- Tiny text to open Taskgroups. Before I could click on any part of the box to open them. Think this is problematic if you have a high resolution, a mouse with high DPI, or maybe a person who has a real problem and shakes a lot. Also is hard when you open one with 7 tasks, and you remember that it wasn't that one, and you want to close, and then you have to move, search for the text...
- Bit picky I think, and probably not needed, is only because of inconsistency. If you click a task in graph view, it only highlights the task in grid view, which makes it hard to find it when you have a lot of Taskgroups. It would be great if it could take you to the task you selected.
- Likely too picky, but I think there is too much space at the footer. It also happened before, but didn't notice it because didn't scroll. I think that's important because if the space didn't exist, all the buttons would be visible without scrolling. For example, if you enter a DAG, click a task in the grid view and think Want to see it in the graph view, you will then click Graph view, and scroll to click `Center selected task`, but then you want to check the Gantt view to check why it took so long, or maybe go to Audit Log, or check the DAG Docs, but at least in my computer I couldn't see them and I had to scroll up again. Thought in removing the header (with Admin, Docs...), but then I thought that could be useful, and I noticed the space in the footer that didn't bring any utility. Also, the annoying part was that I was unable to scroll back up easily because in the graph view the scroll is to zoom, and in the grid view the scroll goes up and down the task list, so I had to f
ind an empty space where the scroll worked to go up the page.
- The DAG Flow is not visible at all. Our main DAGs has around 300 Taskgroups (they are nested, so probably are less of the ones visible in the DAG Flow). In a DAG with 15 Taskgroup great, but in the normal ones can't see anything.
Bugs?
- When you expand a Taskgroup, the last task has a symbol like a ball and an arrow. When there are only a couple Taskgroups the arrow doesn't appear, but if there are a lot the arrow appears and as the number of Taskgroup increases it starts changing. Example:
- If I open a Taskgroup in the graph view, and then I press it, the backgroud of the Taskgroup becomes light blue, and the lines between tasks they go up a couple pixels. We could call it a fun feature for when we are mad because things are not working :smile:, clicking repeatedly makes the line go up and down, becoming more noticeable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #29852: Migrate fully to new graph view
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1525970426
@set92 Mind giving your thoughts on this PR? https://github.com/apache/airflow/pull/30918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #29852: Migrate fully to new graph view
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1520451679
Thanks @set92! This is why we kept the original graph view in for 2.6.0 so that we can refine this new one as much as possible before swapping over completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #29852: Migrate fully to new graph view
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1538501567
> I came here to say the same thing. It would be great if the graph jumped to the task selected from grid. I know there is a Center Selected Task but I feel like that should happen on first click.
>
> I also think Center Selected Task should show the full task group when you click that rather than just zooming in on the name in the top left.
>
> Also the tooltip hover delay feels very short. It pops up constantly as you are panning around which is pretty distracting. Would be great to make that a bit longer.
>
> Awesome job on this new ui @bbovenzi! It is my favorite feature to have come to airflow in years!
Thanks for the feedback!'ll play around with the centering behavior and adding a larger delay for tooltips
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chriscardillo commented on issue #29852: Migrate fully to new graph view
Posted by "chriscardillo (via GitHub)" <gi...@apache.org>.
chriscardillo commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1531921474
The implementation for both `prefix_group_id` and `suffix_group_id` in gusty are separate from the Airflow TaskGroup's `prefix_group_id`, the latter of which will always be `False`, so if you're trying to develop a fix for what we're seeing, you can probably just use an Airflow TaskGroup directly with `prefix_group_id` set to `False`.
Sorry for any confusion, I just caught the issue while bumping Airflow versions in the demos, and it was the easiest way to share what I was seeing, but I think just using an Airflow TaskGroup directly with `prefix_group_id` set to `False` will be enough to troubleshoot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chriscardillo commented on issue #29852: Migrate fully to new graph view
Posted by "chriscardillo (via GitHub)" <gi...@apache.org>.
chriscardillo commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1531766479
Hey hey! Just as an FYI I am seeing some graphs that only render with the pre-2.6.0 graph and not the new 2.6.0 graph. It looks like a task group issue.
Reprex:
- Clone [this demo repo](https://github.com/pipeline-tools/gusty-demo-lite)
- Follow [Running the Demo](https://github.com/pipeline-tools/gusty-demo-lite#running-the-demo) instructions to spin up Airflow.
- Inspect `airflow_tutorial` and `gusty_tutorial` DAGs - no issues with either new or legacy graph views.
- Inspect `more_gusty` DAG - by default the new graph shows nothing.
However, if you expand the tasks, then the graph will render:
My browser's console is giving the following errors when everything's closed:
Hope this is helpful. The new view is looking great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] NilsJPWerner commented on issue #29852: Migrate fully to new graph view
Posted by "NilsJPWerner (via GitHub)" <gi...@apache.org>.
NilsJPWerner commented on issue #29852:
URL: https://github.com/apache/airflow/issues/29852#issuecomment-1533454009
> If you click a task in graph view, it only highlights the task in grid view, which makes it hard to find it when you have a lot of Taskgroups. It would be great if it could take you to the task you selected.
I came here to say the same thing. It would be great if the graph jumped to the task selected from grid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org