You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by timwilkens <gi...@git.apache.org> on 2014/03/22 01:28:11 UTC
[lucy-dev] [GitHub] lucy pull request: Remove clownfish
GitHub user timwilkens opened a pull request:
https://github.com/apache/lucy/pull/5
Remove clownfish
Remove Clownfish from the Lucy repository. This branch eliminates the Perl bindings' dependency on the bundled Clownfish directory.
After applying this patch sequence both the Perl bindings and the C bindings build without error.
Marvin Humphrey and I collaborated on this patch sequence.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/timwilkens/lucy remove_clownfish
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit a13bcf20fa6abc0e1722439592534a3f0e8d8b00
Author: Tim Wilkens <ti...@gmail.com>
Date: 2014-03-21T22:57:06Z
Stop using bundled Clownfish.
Don't use bundled Clownfish compiler or runtime.
Eliminate commands to build bundled Clownfish compiler and runtime.
commit bf2b74521c93c17f7f6edc93f2cd4f3730088d91
Author: Tim Wilkens <ti...@gmail.com>
Date: 2014-03-21T23:15:25Z
Update CPAN prerequisites.
Add Clownfish to `requires`, version not specified.
Add Clownfish::CFC::Perl::Build to `configure_requires`, version not specified.
(This will require a C compiler before even running Build.PL)
commit 5be14f70a2a81987483e83b33efba40a1a46e8c1
Author: Tim Wilkens <ti...@gmail.com>
Date: 2014-03-21T23:19:42Z
Remove bundled Clownfish.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [lucy-dev] [GitHub] lucy pull request: Remove clownfish
Posted by Marvin Humphrey <ma...@rectangular.com>.
On Wed, Apr 9, 2014 at 10:07 AM, Nick Wellnhofer <we...@aevum.de> wrote:
>> I get the following failure:
>>
>> Parcel 'Clownfish' required by 'Lucy' not found at
>> /Library/Perl/5.16/darwin-thread-multi-2level/Clownfish/CFC/Perl/Build.pm
>> line 233.
>>
>> It seems that the system-wide Clownfish include dir for Perl doesn't get
>> added to the search path. I do this for my sample extension in Build.PL:
>>
>>
>> https://github.com/nwellnhof/LucyX-Analysis-WhitespaceTokenizer/blob/master/perl/Build.PL
>>
>> But this should probably be done in Clownfish::CFC::Perl::Build.
>
>
> I'm really blocking on this. If I don't hear any objections, I'll finish the
> Clownfish removal myself.
I'm at ApacheCon and just gave my second talk this morning. I could
work on this tomorrow solo, but won't be able to collaborate with Tim
until next week. I took a stab already and the changes don't seem too
big but have tricky testing interactions to validate correctness.
So, Nick, if you want to finish out the fixes and get the process
unblocked we'd be grateful. No objections from this quarter -- only
thanks.
Marvin Humphrey
Re: [lucy-dev] [GitHub] lucy pull request: Remove clownfish
Posted by Nick Wellnhofer <we...@aevum.de>.
On 22/03/2014 20:17, Nick Wellnhofer wrote:
> On Mar 22, 2014, at 01:28 , timwilkens <gi...@git.apache.org> wrote:
>
>> GitHub user timwilkens opened a pull request:
>>
>> https://github.com/apache/lucy/pull/5
>>
>> Remove clownfish
>>
>> Remove Clownfish from the Lucy repository. This branch eliminates the Perl bindings' dependency on the bundled Clownfish directory.
>>
>> After applying this patch sequence both the Perl bindings and the C bindings build without error.
>>
>> Marvin Humphrey and I collaborated on this patch sequence.
>
> I get the following failure:
>
> Parcel 'Clownfish' required by 'Lucy' not found at /Library/Perl/5.16/darwin-thread-multi-2level/Clownfish/CFC/Perl/Build.pm line 233.
>
> It seems that the system-wide Clownfish include dir for Perl doesn’t get added to the search path. I do this for my sample extension in Build.PL:
>
> https://github.com/nwellnhof/LucyX-Analysis-WhitespaceTokenizer/blob/master/perl/Build.PL
>
> But this should probably be done in Clownfish::CFC::Perl::Build.
I'm really blocking on this. If I don't hear any objections, I'll finish the
Clownfish removal myself.
Nick
Re: [lucy-dev] [GitHub] lucy pull request: Remove clownfish
Posted by Nick Wellnhofer <we...@aevum.de>.
On Mar 22, 2014, at 01:28 , timwilkens <gi...@git.apache.org> wrote:
> GitHub user timwilkens opened a pull request:
>
> https://github.com/apache/lucy/pull/5
>
> Remove clownfish
>
> Remove Clownfish from the Lucy repository. This branch eliminates the Perl bindings' dependency on the bundled Clownfish directory.
>
> After applying this patch sequence both the Perl bindings and the C bindings build without error.
>
> Marvin Humphrey and I collaborated on this patch sequence.
I get the following failure:
Parcel 'Clownfish' required by 'Lucy' not found at /Library/Perl/5.16/darwin-thread-multi-2level/Clownfish/CFC/Perl/Build.pm line 233.
It seems that the system-wide Clownfish include dir for Perl doesn’t get added to the search path. I do this for my sample extension in Build.PL:
https://github.com/nwellnhof/LucyX-Analysis-WhitespaceTokenizer/blob/master/perl/Build.PL
But this should probably be done in Clownfish::CFC::Perl::Build.
Another thing we have to care about is the build bot. After we remove Clownfish from the Lucy tree, the build bot will have to fetch the Clownfish and Lucy repositories and build both projects. We should also take this opportunity to add the C build.
Nick
[lucy-dev] [GitHub] lucy pull request: Remove clownfish
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucy/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---