You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/25 00:34:49 UTC

[GitHub] [spark] sarutak commented on a change in pull request #27687: [SPARK-30943][SS] Show "batch ID" in tool tip string for Structured Streaming UI graphs

sarutak commented on a change in pull request #27687: [SPARK-30943][SS] Show "batch ID" in tool tip string for Structured Streaming UI graphs
URL: https://github.com/apache/spark/pull/27687#discussion_r383594619
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/StreamingQueryStatisticsPage.scala
 ##########
 @@ -114,6 +133,9 @@ private[ui] class StreamingQueryStatisticsPage(parent: StreamingQueryTab)
   def generateStatTable(query: StreamingQueryUIData): Seq[Node] = {
     val batchTimes = withNoProgress(query,
       query.recentProgress.map(p => df.parse(p.timestamp).getTime), Array.empty[Long])
+    val batchToTimestamps = withNoProgress(query,
 
 Review comment:
   Can we create `batchTimes` like `batchToTimestamps.map(_._2)` to avoid having duplicate code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org