You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2023/05/11 10:46:00 UTC

[jira] [Commented] (MSKINS-228) Github Ribbon displaces header menu for width < 980px

    [ https://issues.apache.org/jira/browse/MSKINS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721721#comment-17721721 ] 

Konrad Windszus commented on MSKINS-228:
----------------------------------------

The problem is the {{position: static}} for {{navbar-fixed-top}} at https://github.com/apache/maven-fluido-skin/blob/caa42db9d8de608cbfaa617dd0b3c0242ee12e3a/src/main/resources/css/bootstrap-2.3.2-responsive.css#L958. That conflicts with the ribbon CSS https://github.com/apache/maven-fluido-skin/blob/caa42db9d8de608cbfaa617dd0b3c0242ee12e3a/src/main/resources/css/gh-fork-ribbon.css#L30.

So one workaround would be to always display the top-bar (i.e. keep using {{position: absolute}} even for width < 980).

> Github Ribbon displaces header menu for width < 980px
> -----------------------------------------------------
>
>                 Key: MSKINS-228
>                 URL: https://issues.apache.org/jira/browse/MSKINS-228
>             Project: Maven Skins
>          Issue Type: Bug
>          Components: Fluido Skin
>    Affects Versions: fluido-1.11.0
>            Reporter: Konrad Windszus
>            Priority: Major
>         Attachments: Screenshot 2023-05-11 at 12.28.39.png, Screenshot 2023-05-11 at 12.30.27.png
>
>
> In case the browser width is less than 980px the hamburger menu appears in the header bar. It is hidden though by the GitHub ribbon which inserts an unneeded space at the top.
> See attached screenshots which can be reproduced at https://jackrabbit.apache.org/filevault/index.html
> Width < 980
>  !Screenshot 2023-05-11 at 12.28.39.png! 
> Width >= 980
>  !Screenshot 2023-05-11 at 12.30.27.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)