[jira] Commented: (HBASE-2102) package version used when building contribs is out of sync

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798422#action_12798422 ] 

stack commented on HBASE-2102:
------------------------------

What you thinking andrew?  When we call the src/contrib from top-level, we define version so it overrides version in build-contrib?  Looking at hadoop, this seems to be how it does it (I'm looking at common trunk):

{code}
     <subant target="compile" inheritall="true">
        <property name="version" value="${version}"/>
        <fileset file="${contrib.dir}/build.xml"/>
     </subant>
{code}

> package version used when building contribs is out of sync
> ----------------------------------------------------------
>
>                 Key: HBASE-2102
>                 URL: https://issues.apache.org/jira/browse/HBASE-2102
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Priority: Minor
>
> We are hard coding the package version in src/contrib/build-contrib.xml and it has been out of sync with the package version in the top level build.xml file since 0.20.0. Maybe it would be better to keep the package version in a single separate file (/version.xml?) and include it from all build files?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.