[GitHub] [mynewt-core] sjanc commented on a change in pull request #1743: Additional Wake Up / Reset Reason

[GitBox <gi...@apache.org>]

sjanc commented on a change in pull request #1743: Additional Wake Up / Reset Reason
URL: https://github.com/apache/mynewt-core/pull/1743#discussion_r272489235
 
 

 ##########
 File path: hw/hal/include/hal/hal_system.h
 ##########
 @@ -66,8 +66,10 @@ enum hal_reset_reason {
     HAL_RESET_SOFT = 4,
     /** Low supply voltage */
     HAL_RESET_BROWNOUT = 5,
+    /** Power on */
+    HAL_RESET_POWER_OFF = 6,
     /** Restart due to user request */
-    HAL_RESET_REQUESTED = 6,
+    HAL_RESET_REQUESTED = 7,
 
 Review comment:
   any reason to change HAL_RESET_REQUESTED value? why not just add POWER_OFF at the end of enum?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services