You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "hevinhsu (via GitHub)" <gi...@apache.org> on 2025/05/19 10:35:53 UTC
[PR] HDDS-13032. Support proper S3OwnerId representation in Ozone [ozone]
hevinhsu opened a new pull request, #8478:
URL: https://github.com/apache/ozone/pull/8478
## What changes were proposed in this pull request?
This PR implements [HDDS-13032](https://issues.apache.org/jira/browse/HDDS-13032), which introduces a canonical ownerId for Ozone S3 Gateway responses.
Following the approach discussed in [minio/minio#4553](https://github.com/minio/minio/issues/4553), a default ownerId is generated using the SHA-256 algorithm to ensure the value is deterministic and conforms to the AWS S3 canonical user ID format.
Main changes include:
All ownerId responses now return this default canonical ID.
A new utility method has been added to S3Utils to generate IDs matching the [AWS canonical user ID specification](https://docs.aws.amazon.com/accounts/latest/reference/manage-acct-identifiers.html).
## What is the link to the Apache JIRA
[HDDS-13032](https://issues.apache.org/jira/browse/HDDS-13032)
## How was this patch tested?
https://github.com/hevinhsu/ozone/actions/runs/15109157746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13032. Support proper S3OwnerId representation in Ozone [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8478:
URL: https://github.com/apache/ozone/pull/8478#issuecomment-2893037992
Thanks @hevinhsu for the patch, @chungen0126, @ivandika3 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13032. Support proper S3OwnerId representation in Ozone [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on code in PR #8478:
URL: https://github.com/apache/ozone/pull/8478#discussion_r2096161075
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/util/TestS3Utils.java:
##########
@@ -144,4 +144,10 @@ public void testResolveRepConfWhenUserPassedIsInvalid() throws OS3Exception {
"INVALID", ratis3ReplicationConfig, ratis1ReplicationConfig));
}
+ @Test
+ public void testGenerateCanonicalUserId() {
+ assertEquals("bb2bd7ca4a327f84e6cd3979f8fa3828a50a08893c1b68f9d6715352c8d07b93",
Review Comment:
```suggestion
assertEquals(S3Owner.DEFAULT_S3OWNER_ID,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13032. Support proper S3OwnerId representation in Ozone [ozone]
Posted by "hevinhsu (via GitHub)" <gi...@apache.org>.
hevinhsu commented on code in PR #8478:
URL: https://github.com/apache/ozone/pull/8478#discussion_r2096794726
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/util/TestS3Utils.java:
##########
@@ -144,4 +144,10 @@ public void testResolveRepConfWhenUserPassedIsInvalid() throws OS3Exception {
"INVALID", ratis3ReplicationConfig, ratis1ReplicationConfig));
}
+ @Test
+ public void testGenerateCanonicalUserId() {
+ assertEquals("bb2bd7ca4a327f84e6cd3979f8fa3828a50a08893c1b68f9d6715352c8d07b93",
Review Comment:
Done, thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13032. Support proper S3OwnerId representation in Ozone [ozone]
Posted by "hevinhsu (via GitHub)" <gi...@apache.org>.
hevinhsu commented on PR #8478:
URL: https://github.com/apache/ozone/pull/8478#issuecomment-2890532724
Just a quick note: According to [AWS documentation](https://docs.aws.amazon.com/AmazonS3/latest/API/API_Owner.html), S3Owner.DisplayName will no longer be returned in the future.
Should we track this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13032. Support proper S3OwnerId representation in Ozone [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #8478:
URL: https://github.com/apache/ozone/pull/8478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13032. Support proper S3OwnerId representation in Ozone [ozone]
Posted by "hevinhsu (via GitHub)" <gi...@apache.org>.
hevinhsu commented on PR #8478:
URL: https://github.com/apache/ozone/pull/8478#issuecomment-2893047991
Thanks @ivandika3 @chungen0126 @adoroszlai for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org