You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2025/09/22 22:39:39 UTC
[Impala-ASF-CR] IMPALA-14450: (Addendum) Fix other numeric comparison
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23452
Change subject: IMPALA-14450: (Addendum) Fix other numeric comparison
......................................................................
IMPALA-14450: (Addendum) Fix other numeric comparison
Fixes
set-impala-java-tool-options.sh: line 25: ((: 1.8: syntax error:
invalid arithmetic operator (error token is ".8")
Double parentheses - ((...)) - only support integer arithmetic. I can't
find any standard way to do decimal comparison in shells, so switch to
extract Java major version as an integer and compare that.
OpenJDK 8 has always considered "-target 1.8" and "-target 8" equivalent
https://github.com/openjdk/jdk/blob/jdk8-b01/langtools/src/share/classes/com/sun/tools/javac/jvm/Target.java#L105
so maven target can be set to 8 when IMPALA_JAVA_TARGET is 8.
Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
---
M bin/impala-config.sh
1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/23452/1
--
To view, visit http://gerrit.cloudera.org:8080/23452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
Gerrit-Change-Number: 23452
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-14450: (Addendum) Fix other numeric comparison
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23452 )
Change subject: IMPALA-14450: (Addendum) Fix other numeric comparison
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20560/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
Gerrit-Change-Number: 23452
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 23:06:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14450: (Addendum) Fix other numeric comparison
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23452 )
Change subject: IMPALA-14450: (Addendum) Fix other numeric comparison
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
Gerrit-Change-Number: 23452
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 03:42:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14450: (Addendum) Fix other numeric comparison
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23452 )
Change subject: IMPALA-14450: (Addendum) Fix other numeric comparison
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12520/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
Gerrit-Change-Number: 23452
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 22:57:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14450: (Addendum) Fix other numeric comparison
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23452 )
Change subject: IMPALA-14450: (Addendum) Fix other numeric comparison
......................................................................
Patch Set 1:
Test runs like https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/6804/consoleFull showed the syntax error
/home/ubuntu/Impala/bin/set-impala-java-tool-options.sh: line 25: ((: 1.8: syntax error: invalid arithmetic operator (error token is ".8")
which I can also reproduce locally in bash by sourcing set-impala-java-tool-options.sh.
With this patch, in bash I now see
$ source bin/set-impala-java-tool-options.sh
$ echo $?
0
--
To view, visit http://gerrit.cloudera.org:8080/23452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
Gerrit-Change-Number: 23452
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 23:12:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14450: (Addendum) Fix other numeric comparison
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23452 )
Change subject: IMPALA-14450: (Addendum) Fix other numeric comparison
......................................................................
Patch Set 1: Code-Review+2
Tested it in bash and it works.
--
To view, visit http://gerrit.cloudera.org:8080/23452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
Gerrit-Change-Number: 23452
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 22:47:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14450: (Addendum) Fix other numeric comparison
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23452 )
Change subject: IMPALA-14450: (Addendum) Fix other numeric comparison
......................................................................
IMPALA-14450: (Addendum) Fix other numeric comparison
Fixes
set-impala-java-tool-options.sh: line 25: ((: 1.8: syntax error:
invalid arithmetic operator (error token is ".8")
Double parentheses - ((...)) - only support integer arithmetic. I can't
find any standard way to do decimal comparison in shells, so switch to
extract Java major version as an integer and compare that.
OpenJDK 8 has always considered "-target 1.8" and "-target 8" equivalent
https://github.com/openjdk/jdk/blob/jdk8-b01/langtools/src/share/classes/com/sun/tools/javac/jvm/Target.java#L105
so maven target can be set to 8 when IMPALA_JAVA_TARGET is 8.
Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
Reviewed-on: http://gerrit.cloudera.org:8080/23452
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 6 insertions(+), 7 deletions(-)
Approvals:
Riza Suminto: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
Gerrit-Change-Number: 23452
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>