[GitHub] [tinkerpop] spmallette opened a new pull request #1192: TINKERPOP-1810 Support for withSack() that use Lambdas with remotes

[GitBox <gi...@apache.org>]

spmallette opened a new pull request #1192: TINKERPOP-1810 Support for withSack() that use Lambdas with remotes
URL: https://github.com/apache/tinkerpop/pull/1192
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-1810
   
   To support this we needed to better detect the number of arguments that a lambda has so that we can properly deserialize to BinaryOperator or UnaryOperator. We also needed to better cast arguments for groovy given withSack() overlaods that aren't easily detected during eval() and generate errors otherwise. The method for detecting arguments isn't super nice - just some string parsing, but since Gremlin really only ever expects zero, one or two arg lambdas the risk of taking this approach seems low. Note that users who want to distinguish arguments must specify them with a full groovy closure syntax or else it will assume "unknown" as it always has.
   
   All tests pass with `docker/build.sh -t -i`
   
   VOTE +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services