You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/16 09:17:21 UTC

[GitHub] [pulsar] nicoloboschi commented on a change in pull request #13057: [Producer] Change the time units from ns to ms

nicoloboschi commented on a change in pull request #13057:
URL: https://github.com/apache/pulsar/pull/13057#discussion_r770352823



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -1292,6 +1293,12 @@ protected OpSendMsg newObject(Handle<OpSendMsg> handle) {
         };
     }
 
+    private static double nsToSeconds(long ns) {

Review comment:
       I would expect this find this method in a utility class




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org