RE: svn commit: r1073043 - in /subversion/trunk/subversion: include/svn_delta.h mod_dav_svn/mod_dav_svn.c svnserve/main.c

[Bert Huijben <be...@qqmail.nl>]

> -----Original Message-----
> From: philip@apache.org [mailto:philip@apache.org]
> Sent: maandag 21 februari 2011 17:08
> To: commits@subversion.apache.org
> Subject: svn commit: r1073043 - in /subversion/trunk/subversion:
> include/svn_delta.h mod_dav_svn/mod_dav_svn.c svnserve/main.c
> 
> Author: philip
> Date: Mon Feb 21 16:08:15 2011
> New Revision: 1073043
> 
> URL: http://svn.apache.org/viewvc?rev=1073043&view=rev
> Log:
> Avoid using "best" to refer to maximum compression.
> 
> * subversion/include/svn_delta.h
>   (SVN_BEST_COMPRESSION_LEVEL): Renamed to ...
>   (SVN_MAX_COMPRESSION_LEVEL): ... this.
> 
> * subversion/svnserve/main.c
>   (main): Adjust for rename.
> 
> * subversion/mod_dav_svn/mod_dav_svn.c
>   (SVNCompressionLevel_cmd): Adjust for rename.
>   (cmds): Use "maximum" rather than "best", don't refer to "ZIP".
> 
> Modified:
>     subversion/trunk/subversion/include/svn_delta.h
>     subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
>     subversion/trunk/subversion/svnserve/main.c
> 
> Modified: subversion/trunk/subversion/include/svn_delta.h
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_de
> lta.h?rev=1073043&r1=1073042&r2=1073043&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/include/svn_delta.h (original)
> +++ subversion/trunk/subversion/include/svn_delta.h Mon Feb 21 16:08:15
> 2011
> @@ -56,7 +56,7 @@ extern "C" {
> 
>  /** This is the maximum compression level we can pass to zlib.
>   */
> -#define SVN_BEST_COMPRESSION_LEVEL 9
> +#define SVN_MAX_COMPRESSION_LEVEL 9

Is this macro new in 1.7?

If it is we should document it as new and if not the old name should be properly deprecated.


	Bert

Re: svn commit: r1073043 - in /subversion/trunk/subversion: include/svn_delta.h mod_dav_svn/mod_dav_svn.c svnserve/main.c

[Stefan Fuhrmann <eq...@web.de>]

On 21.02.2011 22:17, Bert Huijben wrote:
>> --- subversion/trunk/subversion/include/svn_delta.h (original)
>> +++ subversion/trunk/subversion/include/svn_delta.h Mon Feb 21 16:08:15
>> 2011
>> @@ -56,7 +56,7 @@ extern "C" {
>>
>>   /** This is the maximum compression level we can pass to zlib.
>>    */
>> -#define SVN_BEST_COMPRESSION_LEVEL 9
>> +#define SVN_MAX_COMPRESSION_LEVEL 9
> Is this macro new in 1.7?
>
> If it is we should document it as new and if not the old name should be properly deprecated.
Oops. Fixed in r1073242.

-- Stefan^2.