You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "2han9wen71an (via GitHub)" <gi...@apache.org> on 2023/02/02 08:36:57 UTC
[GitHub] [skywalking-java] 2han9wen71an opened a new pull request, #447: 修复h2插件拦截点异常
2han9wen71an opened a new pull request, #447:
URL: https://github.com/apache/skywalking-java/pull/447
- [x] 异常路径 `org.apache.skywalking.apm.plugin.jdbc.jdbc.JdbcXAConnectionConstructorInterceptor` 在整个仓库不存在，查看功能发现目前正确路径为 `org.apache.skywalking.apm.plugin.jdbc.h2.JdbcXAConnectionConstructorInterceptor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #447: 修复h2插件拦截点异常
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #447:
URL: https://github.com/apache/skywalking-java/pull/447#issuecomment-1413423236
@pg-yang Could you check on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #447: Fix H2 instrumentation point
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #447:
URL: https://github.com/apache/skywalking-java/pull/447#issuecomment-1413713996
@2han9wen71an Once changes updated, this PR should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #447: Fix H2 instrumentation point
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #447:
URL: https://github.com/apache/skywalking-java/pull/447#issuecomment-1413523470
There is a changes.md in the root. Please update as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #447: 修复h2插件拦截点异常
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #447:
URL: https://github.com/apache/skywalking-java/pull/447#issuecomment-1413378200
We only accept English description. Could you update them? And changelog should be updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] 2han9wen71an commented on pull request #447: Fix H2 instrumentation point
Posted by "2han9wen71an (via GitHub)" <gi...@apache.org>.
2han9wen71an commented on PR #447:
URL: https://github.com/apache/skywalking-java/pull/447#issuecomment-1413506769
> We only accept English description. Could you update them? And changelog should be updated as well.
english description updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #447: Fix H2 instrumentation point
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #447:
URL: https://github.com/apache/skywalking-java/pull/447#issuecomment-1413803250
That is better. Before you propose changes, please submit a discuss to explain why it didn't work and what is your solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] pg-yang commented on pull request #447: Fix H2 instrumentation point
Posted by "pg-yang (via GitHub)" <gi...@apache.org>.
pg-yang commented on PR #447:
URL: https://github.com/apache/skywalking-java/pull/447#issuecomment-1413711327
I've confirmed the class name is wrong indeed. Let's wait for `changes.md `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #447: Fix H2 instrumentation point
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #447:
URL: https://github.com/apache/skywalking-java/pull/447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] pg-yang commented on pull request #447: 修复h2插件拦截点异常
Posted by "pg-yang (via GitHub)" <gi...@apache.org>.
pg-yang commented on PR #447:
URL: https://github.com/apache/skywalking-java/pull/447#issuecomment-1413430735
> @pg-yang Could you check on this?
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] 2han9wen71an commented on pull request #447: Fix H2 instrumentation point
Posted by "2han9wen71an (via GitHub)" <gi...@apache.org>.
2han9wen71an commented on PR #447:
URL: https://github.com/apache/skywalking-java/pull/447#issuecomment-1413778633
> @2han9wen71an一旦更改更新，这个 PR 应该是好的。
> @2han9wen71an Once changes updated, this PR should be good.
Updated, I've recently been fixing skywalking not working under osgi environment, and it has been verified successfully under polarion so far. Looking forward to our next meeting!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org