You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by wa...@apache.org on 2026/10/01 11:49:24 UTC
(shenyu) branch master updated: [ISSUE #7393] Align DataChangedEventDispatcherTest verifications with the 3-arg onPluginChanged overload (#7395)
This is an automated email from the ASF dual-hosted git repository.
wy471x pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shenyu.git
The following commit(s) were added to refs/heads/master by this push:
new 08e87ee7a5 [ISSUE #7393] Align DataChangedEventDispatcherTest verifications with the 3-arg onPluginChanged overload (#7395)
08e87ee7a5 is described below
commit 08e87ee7a5a80e70edd3a81dcd5ddf2207fef497
Author: eye-gu <ey...@apache.org>
AuthorDate: Thu Oct 1 19:49:19 2026 +0800
[ISSUE #7393] Align DataChangedEventDispatcherTest verifications with the 3-arg onPluginChanged overload (#7395)
* Fixes #7393: align DataChangedEventDispatcherTest with the 3-arg onPluginChanged overload
* Also align the never() verifications in transaction tests with the 3-arg onPluginChanged overload
---
.../admin/listener/DataChangedEventDispatcherTest.java | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/shenyu-admin/src/test/java/org/apache/shenyu/admin/listener/DataChangedEventDispatcherTest.java b/shenyu-admin/src/test/java/org/apache/shenyu/admin/listener/DataChangedEventDispatcherTest.java
index 70a5e9cd32..901a213c68 100644
--- a/shenyu-admin/src/test/java/org/apache/shenyu/admin/listener/DataChangedEventDispatcherTest.java
+++ b/shenyu-admin/src/test/java/org/apache/shenyu/admin/listener/DataChangedEventDispatcherTest.java
@@ -340,9 +340,9 @@ public final class DataChangedEventDispatcherTest {
DataChangedEvent dataChangedEvent = new DataChangedEvent(ConfigGroupEnum.PLUGIN, null, new ArrayList<>());
dataChangedEventDispatcher.onApplicationEvent(dataChangedEvent);
verify(clusterDataChangedEventForwarder, times(1)).forward(dataChangedEvent);
- verify(httpLongPollingDataChangedListener, times(1)).onPluginChanged(anyList(), any());
- verify(nacosDataChangedListener, never()).onPluginChanged(anyList(), any());
- verify(websocketDataChangedListener, never()).onPluginChanged(anyList(), any());
+ verify(httpLongPollingDataChangedListener, times(1)).onPluginChanged(anyList(), any(), any());
+ verify(nacosDataChangedListener, never()).onPluginChanged(anyList(), any(), any());
+ verify(websocketDataChangedListener, never()).onPluginChanged(anyList(), any(), any());
}
/**
@@ -356,8 +356,8 @@ public final class DataChangedEventDispatcherTest {
DataChangedEvent dataChangedEvent = new DataChangedEvent(ConfigGroupEnum.PLUGIN, null, new ArrayList<>());
dataChangedEventDispatcher.onApplicationEvent(dataChangedEvent);
verify(clusterDataChangedEventForwarder, times(1)).forward(dataChangedEvent);
- verify(httpLongPollingDataChangedListener, times(1)).onPluginChanged(anyList(), any());
- verify(websocketDataChangedListener, never()).onPluginChanged(anyList(), any());
+ verify(httpLongPollingDataChangedListener, times(1)).onPluginChanged(anyList(), any(), any());
+ verify(websocketDataChangedListener, never()).onPluginChanged(anyList(), any(), any());
}
/**
@@ -369,8 +369,8 @@ public final class DataChangedEventDispatcherTest {
DataChangedEvent dataChangedEvent = new DataChangedEvent(ConfigGroupEnum.PLUGIN, null, new ArrayList<>());
dataChangedEventDispatcher.onApplicationEvent(dataChangedEvent);
verify(clusterDataChangedEventForwarder, never()).forward(any(DataChangedEvent.class));
- verify(websocketDataChangedListener, times(1)).onPluginChanged(anyList(), any());
- verify(httpLongPollingDataChangedListener, times(1)).onPluginChanged(anyList(), any());
+ verify(websocketDataChangedListener, times(1)).onPluginChanged(anyList(), any(), any());
+ verify(httpLongPollingDataChangedListener, times(1)).onPluginChanged(anyList(), any(), any());
}
@Test
@@ -383,7 +383,7 @@ public final class DataChangedEventDispatcherTest {
DataChangedEvent event = new DataChangedEvent(ConfigGroupEnum.PLUGIN, null, new ArrayList<>());
dataChangedEventDispatcher.onApplicationEvent(event);
verify(clusterDataChangedEventForwarder, never()).forward(any());
- verify(httpLongPollingDataChangedListener, never()).onPluginChanged(anyList(), any());
+ verify(httpLongPollingDataChangedListener, never()).onPluginChanged(anyList(), any(), any());
org.springframework.transaction.support.TransactionSynchronizationManager.getSynchronizations()
.forEach(org.springframework.transaction.support.TransactionSynchronization::afterCommit);
verify(clusterDataChangedEventForwarder).forward(event);
@@ -402,7 +402,7 @@ public final class DataChangedEventDispatcherTest {
org.springframework.transaction.support.TransactionSynchronizationManager.getSynchronizations()
.forEach(sync -> sync.afterCompletion(org.springframework.transaction.support.TransactionSynchronization.STATUS_ROLLED_BACK));
verify(clusterDataChangedEventForwarder, never()).forward(any());
- verify(httpLongPollingDataChangedListener, never()).onPluginChanged(anyList(), any());
+ verify(httpLongPollingDataChangedListener, never()).onPluginChanged(anyList(), any(), any());
} finally {
org.springframework.transaction.support.TransactionSynchronizationManager.clear();
}