You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lahodaj (via GitHub)" <gi...@apache.org> on 2024/01/04 09:09:42 UTC
[PR] Forcing restart when to_enable.txt file exists in the Windows launcher. [netbeans]
lahodaj opened a new pull request, #6914:
URL: https://github.com/apache/netbeans/pull/6914
Transferring this PR (only the part with `to_enable.txt`):
https://github.com/apache/netbeans-native-launchers/pull/11
into the main repository.
It should be eventually used by:
https://github.com/apache/netbeans/pull/6743
Not sure if this should be separate like here (hence the launcher would be updated, and could be released, and then used by 6743), or part of 6743, and the launcher would be updated later. I guess I'd prefer first updating the launcher, so that there's no point where 6743 would not work on Windows, but I can do it differently if desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Forcing restart when to_enable.txt file exists in the Windows launcher. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6914:
URL: https://github.com/apache/netbeans/pull/6914#issuecomment-1881582901
@lahodaj Thanks. Triggered build, staged artefacts, and opened #6933 which temporarily includes your other changes for testing. Please check over the build, which should show up on https://github.com/apache/netbeans/actions/runs/7451103492 when CI is done. Either +1 the vote or let me know if there are issues and we need to pull the artefact vote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Forcing restart when to_enable.txt file exists in the Windows launcher. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6914:
URL: https://github.com/apache/netbeans/pull/6914#issuecomment-1877299145
This needs to merge separately, and first. We should merge this, then stage the launcher artefacts for vote and update #6743 to link with the staged launcher with a test build. Once the vote completes, update #6743 with the final artefact location for the launchers prior to merging that.
I was hoping to get another fix (for relative jdkhome) into the launcher, but will defer that for now and look in NB22 timeframe. So as soon as this is in I'll trigger a build and vote.
See #6521 for a similar process that was used to update the terminal natives.
Feel free to merge this as and when other reviews complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Forcing restart when to_enable.txt file exists in the Windows launcher. [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #6914:
URL: https://github.com/apache/netbeans/pull/6914#issuecomment-1880735179
Thanks, merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Forcing restart when to_enable.txt file exists in the Windows launcher. [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #6914:
URL: https://github.com/apache/netbeans/pull/6914#issuecomment-1879054187
@neilcsmith-net - sure I'll do my best to integrate by Monday morning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Forcing restart when to_enable.txt file exists in the Windows launcher. [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #6914:
URL: https://github.com/apache/netbeans/pull/6914#issuecomment-1880482823
@ebarboni - any insights on this? It would be nice to merge this sometime very soon. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Forcing restart when to_enable.txt file exists in the Windows launcher. [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj merged PR #6914:
URL: https://github.com/apache/netbeans/pull/6914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Forcing restart when to_enable.txt file exists in the Windows launcher. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6914:
URL: https://github.com/apache/netbeans/pull/6914#issuecomment-1878919925
If this is merged by Monday AM, I can look at the build staging and vote for the native artefacts. Realistically, if we can't kick off the vote on Monday, I doubt we'll be able to integrate before freeze for NB21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Forcing restart when to_enable.txt file exists in the Windows launcher. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6914:
URL: https://github.com/apache/netbeans/pull/6914#issuecomment-1880706713
Feel free to merge. I'll look at the vote build ASAP. I pinged Eric to see if he had comments on the change or release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Forcing restart when to_enable.txt file exists in the Windows launcher. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6914:
URL: https://github.com/apache/netbeans/pull/6914#issuecomment-1885101215
@lahodaj the vote is open at https://lists.apache.org/thread/00y6b4qzf7rj7lm9mynwcr07kom9sgxf We need to verify and pass this on time tomorrow or we will have to push the #6743 changes to NB22.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists