[jira] Commented: (DERBY-2977) Replication: Add a ReplicationMaster controller that will manage replication on the master side

["Øystein Grøvlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535534 ] 

Øystein Grøvlen commented on DERBY-2977:
----------------------------------------

Thanks for addressing my comments in the new patch, Jørgen.  I have
just a few minor follow-up comments (same numbering as in my previous
review):

1. Your basically looks good.  IMHO, calling the new method
   'checkForReplication' or something instead of
   'initLogAccessFileReplication' since it will not always init
   replication.  (Check is also the main verb you use to describe in
   the javadoc what it is doing.)  

   As an alternative to 'startReplicationMasterRole', I suggest
   'setReplicationMasterRole', since as I said, it is not always
   starting replication.

2. A third alternative implementation that will behave almost the same
   as the current strategy as seen from the user, is to remember any
   logFileSwitch at the end of a log chunk until the next chunk
   arrives, and let switchLogFile() be true for the first log record
   of the next chunk.  Then, removing 'else' will be the only necessary change
   to your example code.

4. As far as I can see, you have not addressed this typo.

9. I think I meant LogAccessFile#stopReplicationMasterRole.  Anyway,
   it is fixed now.

10. (NEW) To me, adding instant as a parameter to
    LogAccessFile#writeToLog seems like a better solution than
    maintaining a field 'instantCurrentChunk'.

None of the above issues are very important, and it is your
call whether you would like to fix any of them before I commit.

> Replication: Add a ReplicationMaster controller that will manage replication on the master side
> -----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2977
>                 URL: https://issues.apache.org/jira/browse/DERBY-2977
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Services
>    Affects Versions: 10.4.0.0
>            Reporter: Jørgen Løland
>            Assignee: Jørgen Løland
>         Attachments: derby_2977_1.diff, derby_2977_1.stat, derby_2977_1b.diff, derby_2977_1b.stat, derby_2977_1c.diff, derby_2977_1c.stat, repli_logbuffer_v2.diff, repli_logbuffer_v2.stat, repli_logbuffer_v2b.diff, repli_logbuffer_v2b.stat, repli_logbuffer_v2c.diff, repli_logbuffer_v2c.stat
>
>
> The replication master role includes many tasks:
> * set up a network connection to the slave
> * sending the database to the slave before starting replication
> * make sure that log records are appended to the network buffer, and that the log is later sent to the slave
> * etc
> This issue is for adding a controller that will start/stop/initiate all services needed for the replication master role.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.