You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "lipengfei28 (via GitHub)" <gi...@apache.org> on 2025/11/25 08:22:14 UTC
[PR] pci:write legacy num to config sapce when enable legacy irq [nuttx]
lipengfei28 opened a new pull request, #17379:
URL: https://github.com/apache/nuttx/pull/17379
write legacy num to config sapce when enable legacy irq
*Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.*
## Impact
*Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.*
## Testing
*This section should provide a detailed description of what you did
to verify your changes work and do not break existing code.*
*Please provide information about your host machine, the board(s) you
tested your changes on, and how you tested. Logs should be included.*
*For example, when changing something in the core OS functions, you
may want to run the OSTest application to verify that there are no
regressions. Changes to ADC code may warrant running the `adc`
example. Adding a new uORB driver may require that you run
`uorb_listener` to verify correct operation.*
*Pure documentation changes can just be tested with `make html`
(see docs) and verification of the correct format in your
browser.*
**_PRs without testing information will not be accepted. We will
request test logs._**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/pci: write legacy num to config sapce when enable legacy irq [nuttx]
Posted by "lipengfei28 (via GitHub)" <gi...@apache.org>.
lipengfei28 commented on PR #17379:
URL: https://github.com/apache/nuttx/pull/17379#issuecomment-3575294955
> please update the commit titles to use standard format drivers/pci: write legacy num to config sapce when enable legacy irq drivers/pci: fix pci_disable_irq/pci_enable_irq parameter
>
> in the commit description please write details about the change
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/pci: write legacy num to config sapce when enable legacy irq [nuttx]
Posted by "linguini1 (via GitHub)" <gi...@apache.org>.
linguini1 commented on PR #17379:
URL: https://github.com/apache/nuttx/pull/17379#issuecomment-3812017786
Can explain the errors in the logs? I.e not being able to find the block drivers or interact with ROMFS?
The logs look good otherwise. A tip for the future is tou can surround the logs with three backticks on either side and it will format them nicely! Makes it easier to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/pci: write legacy num to config sapce when enable legacy irq [nuttx]
Posted by "lipengfei28 (via GitHub)" <gi...@apache.org>.
lipengfei28 commented on PR #17379:
URL: https://github.com/apache/nuttx/pull/17379#issuecomment-3815662829
> ```
> ap> [ 6.605642] [14] [ ERROR] [ap] romfs_open: ERROR: Failed to find directory directory entry for 'pci.ids.gz': -2
> ```
There is no pci.ids.gz file under the /etc directory. This file is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/pci: write legacy num to config sapce when enable legacy irq [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #17379:
URL: https://github.com/apache/nuttx/pull/17379#issuecomment-3574890433
@lipengfei28 please fix typo in your commit title: sapce -> space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/pci: write legacy num to config sapce when enable legacy irq [nuttx]
Posted by "lipengfei28 (via GitHub)" <gi...@apache.org>.
lipengfei28 commented on PR #17379:
URL: https://github.com/apache/nuttx/pull/17379#issuecomment-3809402306
> Please review the contribution guidelines and update your PR description to meet the requirements: https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
Please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/pci: write legacy num to config sapce when enable legacy irq [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #17379:
URL: https://github.com/apache/nuttx/pull/17379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org