You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "valepakh (via GitHub)" <gi...@apache.org> on 2025/08/08 13:51:37 UTC
[PR] IGNITE-26176 Close result set [ignite-3]
valepakh opened a new pull request, #6396:
URL: https://github.com/apache/ignite-3/pull/6396
https://issues.apache.org/jira/browse/IGNITE-26176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26176 Close result set [ignite-3]
Posted by "PakhomovAlexander (via GitHub)" <gi...@apache.org>.
PakhomovAlexander merged PR #6396:
URL: https://github.com/apache/ignite-3/pull/6396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26176 Close result set [ignite-3]
Posted by "dant3 (via GitHub)" <gi...@apache.org>.
dant3 commented on code in PR #6396:
URL: https://github.com/apache/ignite-3/pull/6396#discussion_r2263109721
##########
modules/compatibility-tests/src/testFixtures/java/org/apache/ignite/internal/CompatibilityTestBase.java:
##########
@@ -164,8 +166,12 @@ protected List<List<Object>> sql(String query) {
return sql(node(0), query);
}
- protected List<List<Object>> sql(Ignite ignite, String query) {
- return ClusterPerClassIntegrationTest.sql(ignite, null, null, null, query);
+ protected static List<List<Object>> sql(Ignite ignite, String query) {
+ return sql(ignite, null, query);
+ }
+
+ protected static List<List<Object>> sql(Ignite ignite, @Nullable Transaction tx, String query) {
+ return ClusterPerClassIntegrationTest.sql(ignite, tx, null, null, query);
Review Comment:
Lets also add `Object... args` passing here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26176 Close result set [ignite-3]
Posted by "valepakh (via GitHub)" <gi...@apache.org>.
valepakh commented on code in PR #6396:
URL: https://github.com/apache/ignite-3/pull/6396#discussion_r2263124736
##########
modules/compatibility-tests/src/testFixtures/java/org/apache/ignite/internal/CompatibilityTestBase.java:
##########
@@ -164,8 +166,12 @@ protected List<List<Object>> sql(String query) {
return sql(node(0), query);
}
- protected List<List<Object>> sql(Ignite ignite, String query) {
- return ClusterPerClassIntegrationTest.sql(ignite, null, null, null, query);
+ protected static List<List<Object>> sql(Ignite ignite, String query) {
+ return sql(ignite, null, query);
+ }
+
+ protected static List<List<Object>> sql(Ignite ignite, @Nullable Transaction tx, String query) {
+ return ClusterPerClassIntegrationTest.sql(ignite, tx, null, null, query);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org