You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2012/06/20 02:51:19 UTC

Review Request: Bug fix in killtree.sh. (Showing "Syntax error: Bad fd number")

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5429/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Description
-------

On certain linux machine (e.g. my virtual machine), the slave shows the following error:

I0606 16:48:25.485646 20092 slave.cpp:1507] Scheduling executor directory /tmp/mesos/slaves/201206061648-16842879-5432-20059-0/frameworks/201206061648-16842879-5432-20059-0000/executors/default/runs/0 for deletion
/home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: 94: /home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: Syntax error: Bad fd number
I0606 16:48:25.484307 20093 process_utils.hpp:64]


Diffs
-----

  src/scripts/killtree.sh 2d8b860 

Diff: https://reviews.apache.org/r/5429/diff/


Testing
-------

Make check.


Thanks,

Jie Yu


Re: Review Request: Bug fix in killtree.sh. (Showing "Syntax error: Bad fd number")

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5429/#review8410
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On June 20, 2012, 12:51 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5429/
> -----------------------------------------------------------
> 
> (Updated June 20, 2012, 12:51 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Description
> -------
> 
> On certain linux machine (e.g. my virtual machine), the slave shows the following error:
> 
> I0606 16:48:25.485646 20092 slave.cpp:1507] Scheduling executor directory /tmp/mesos/slaves/201206061648-16842879-5432-20059-0/frameworks/201206061648-16842879-5432-20059-0000/executors/default/runs/0 for deletion
> /home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: 94: /home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: Syntax error: Bad fd number
> I0606 16:48:25.484307 20093 process_utils.hpp:64]
> 
> 
> Diffs
> -----
> 
>   src/scripts/killtree.sh 2d8b860 
> 
> Diff: https://reviews.apache.org/r/5429/diff/
> 
> 
> Testing
> -------
> 
> Make check.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request: Bug fix in killtree.sh. (Showing "Syntax error: Bad fd number")

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5429/#review8860
-----------------------------------------------------------

Ship it!


awesome, thanx!

- Vinod Kone


On July 3, 2012, 8:53 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5429/
> -----------------------------------------------------------
> 
> (Updated July 3, 2012, 8:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> On certain linux machine (e.g. my virtual machine), the slave shows the following error:
> 
> I0606 16:48:25.485646 20092 slave.cpp:1507] Scheduling executor directory /tmp/mesos/slaves/201206061648-16842879-5432-20059-0/frameworks/201206061648-16842879-5432-20059-0000/executors/default/runs/0 for deletion
> /home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: 94: /home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: Syntax error: Bad fd number
> I0606 16:48:25.484307 20093 process_utils.hpp:64]
> 
> 
> Diffs
> -----
> 
>   src/scripts/killtree.sh 2d8b860 
> 
> Diff: https://reviews.apache.org/r/5429/diff/
> 
> 
> Testing
> -------
> 
> Make check.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request: Bug fix in killtree.sh. (Showing "Syntax error: Bad fd number")

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5429/#review9030
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 3, 2012, 8:53 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5429/
> -----------------------------------------------------------
> 
> (Updated July 3, 2012, 8:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> On certain linux machine (e.g. my virtual machine), the slave shows the following error:
> 
> I0606 16:48:25.485646 20092 slave.cpp:1507] Scheduling executor directory /tmp/mesos/slaves/201206061648-16842879-5432-20059-0/frameworks/201206061648-16842879-5432-20059-0000/executors/default/runs/0 for deletion
> /home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: 94: /home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: Syntax error: Bad fd number
> I0606 16:48:25.484307 20093 process_utils.hpp:64]
> 
> 
> Diffs
> -----
> 
>   src/scripts/killtree.sh 2d8b860 
> 
> Diff: https://reviews.apache.org/r/5429/diff/
> 
> 
> Testing
> -------
> 
> Make check.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request: Bug fix in killtree.sh. (Showing "Syntax error: Bad fd number")

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5429/
-----------------------------------------------------------

(Updated July 3, 2012, 8:53 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Remove 'x' from ps (see Vinod's comments).


Description
-------

On certain linux machine (e.g. my virtual machine), the slave shows the following error:

I0606 16:48:25.485646 20092 slave.cpp:1507] Scheduling executor directory /tmp/mesos/slaves/201206061648-16842879-5432-20059-0/frameworks/201206061648-16842879-5432-20059-0000/executors/default/runs/0 for deletion
/home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: 94: /home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: Syntax error: Bad fd number
I0606 16:48:25.484307 20093 process_utils.hpp:64]


Diffs (updated)
-----

  src/scripts/killtree.sh 2d8b860 

Diff: https://reviews.apache.org/r/5429/diff/


Testing
-------

Make check.


Thanks,

Jie Yu


Re: Review Request: Bug fix in killtree.sh. (Showing "Syntax error: Bad fd number")

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5429/#review8850
-----------------------------------------------------------



src/scripts/killtree.sh
<https://reviews.apache.org/r/5429/#comment18819>

    Jie, can you get rid of  'x' option in ps here.
    
    Doesn't work as expected on linux and is redundant.
    
    Thanks.


- Vinod Kone


On June 20, 2012, 12:51 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5429/
> -----------------------------------------------------------
> 
> (Updated June 20, 2012, 12:51 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Description
> -------
> 
> On certain linux machine (e.g. my virtual machine), the slave shows the following error:
> 
> I0606 16:48:25.485646 20092 slave.cpp:1507] Scheduling executor directory /tmp/mesos/slaves/201206061648-16842879-5432-20059-0/frameworks/201206061648-16842879-5432-20059-0000/executors/default/runs/0 for deletion
> /home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: 94: /home/jyu/workspace/mesos/install/libexec/mesos/killtree.sh: Syntax error: Bad fd number
> I0606 16:48:25.484307 20093 process_utils.hpp:64]
> 
> 
> Diffs
> -----
> 
>   src/scripts/killtree.sh 2d8b860 
> 
> Diff: https://reviews.apache.org/r/5429/diff/
> 
> 
> Testing
> -------
> 
> Make check.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>