You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrea Turli <no...@github.com> on 2015/06/25 11:34:41 UTC
[jclouds] Minor changes to openstack-nova and openstack-keystone
(#783)
- change some access modifiers to simplify the downstream provider impl
- modify the BasicAuthenticator in Keystone
@zack-shoylev, @jdaggett as openstack experts, could you give it a quick look please?
Thanks!
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/783
-- Commit Summary --
* change some access modifiers to simplify the downstream provider impl
-- File Changes --
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/functions/internal/BaseAuthenticator.java (6)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeServiceAdapter.java (23)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/functions/ImageToOperatingSystem.java (2)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/functions/ServerInRegionToNodeMetadata.java (4)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java (6)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/783.patch
https://github.com/jclouds/jclouds/pull/783.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/783
Re: [jclouds] Minor changes to openstack-nova and openstack-keystone
(#783)
Posted by Andrea Turli <no...@github.com>.
@nacx those are basic changes, do you think we can merge them for the upcoming release (1.9.1)
It would be a huge help!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/783#issuecomment-115191610
Re: [jclouds] Minor changes to openstack-nova and openstack-keystone
(#783)
Posted by Ignasi Barrera <no...@github.com>.
lgtm. Thanks @andreaturli!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/783#issuecomment-115666103
Re: [jclouds] Minor changes to openstack-nova and openstack-keystone
(#783)
Posted by Andrea Turli <no...@github.com>.
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/aa64e0d3) and backported to [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4ac9a73d)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/783#issuecomment-115673949
Re: [jclouds] Minor changes to openstack-nova and openstack-keystone
(#783)
Posted by Andrea Turli <no...@github.com>.
Closed #783.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/783#event-341132688
Re: [jclouds] Minor changes to openstack-nova and openstack-keystone
(#783)
Posted by Ignasi Barrera <no...@github.com>.
> String imageId = template.getImage().getProviderId();
> String flavorId = template.getHardware().getProviderId();
>
> logger.debug(">> creating new server region(%s) name(%s) image(%s) flavor(%s) options(%s)", regionId, name, imageId, flavorId, options);
> - ServerCreated lightweightServer = novaApi.getServerApi(regionId).create(name, imageId, flavorId, options);
> - Server server = novaApi.getServerApi(regionId).get(lightweightServer.getId());
> -
> - logger.trace("<< server(%s)", server.getId());
> + final ServerCreated lightweightServer = novaApi.getServerApi(regionId).create(name, imageId, flavorId, options);
> + if (!retry(new Predicate<String>() {
> + @Override
> + public boolean apply(String serverId) {
> + Server server = novaApi.getServerApi(regionId).get(serverId);
> + return server != null && server.getAddresses() != null && !server.getAddresses().isEmpty();
> + }
> + }, 30 * 60, 1, SECONDS).apply(lightweightServer.getId())) {
> + final String message = format("Server %s was not created within %sms so it will be destroyed.", name, "30 * 60");
Where is the server destroyed?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/783/files#r33240787
Re: [jclouds] Minor changes to openstack-nova and openstack-keystone
(#783)
Posted by Andrea Turli <no...@github.com>.
> String imageId = template.getImage().getProviderId();
> String flavorId = template.getHardware().getProviderId();
>
> logger.debug(">> creating new server region(%s) name(%s) image(%s) flavor(%s) options(%s)", regionId, name, imageId, flavorId, options);
> - ServerCreated lightweightServer = novaApi.getServerApi(regionId).create(name, imageId, flavorId, options);
> - Server server = novaApi.getServerApi(regionId).get(lightweightServer.getId());
> -
> - logger.trace("<< server(%s)", server.getId());
> + final ServerCreated lightweightServer = novaApi.getServerApi(regionId).create(name, imageId, flavorId, options);
> + if (!retry(new Predicate<String>() {
> + @Override
> + public boolean apply(String serverId) {
> + Server server = novaApi.getServerApi(regionId).get(serverId);
> + return server != null && server.getAddresses() != null && !server.getAddresses().isEmpty();
> + }
> + }, 30 * 60, 1, SECONDS).apply(lightweightServer.getId())) {
> + final String message = format("Server %s was not created within %sms so it will be destroyed.", name, "30 * 60");
ops, you're right! adding it now
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/783/files#r33241172