You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/05 19:59:24 UTC
[GitHub] [incubator-kvrocks] tisonkun opened a new pull request, #939: refactor: go cases with var flags
tisonkun opened a new pull request, #939:
URL: https://github.com/apache/incubator-kvrocks/pull/939
This closes https://github.com/apache/incubator-kvrocks/issues/862.
* run `./x.py test go build -deleteOnExit=true` to delete workspace files on exit. Default to `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #939: refactor: go cases with var flags
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #939:
URL: https://github.com/apache/incubator-kvrocks/pull/939#discussion_r985493920
##########
tests/gocase/util/server.go:
##########
@@ -78,7 +83,7 @@ func (s *KvrocksServer) Close() {
}
func StartServer(t testing.TB, configs map[string]string) *KvrocksServer {
- b := os.Getenv("KVROCKS_BIN_PATH")
+ b := *binPath
require.NotEmpty(t, b, "please set the environment variable `KVROCKS_BIN_PATH`")
Review Comment:
```suggestion
```
##########
tests/gocase/util/server.go:
##########
@@ -78,7 +83,7 @@ func (s *KvrocksServer) Close() {
}
func StartServer(t testing.TB, configs map[string]string) *KvrocksServer {
- b := os.Getenv("KVROCKS_BIN_PATH")
+ b := *binPath
require.NotEmpty(t, b, "please set the environment variable `KVROCKS_BIN_PATH`")
Review Comment:
Change this error message?
##########
tests/gocase/util/server.go:
##########
@@ -78,7 +83,7 @@ func (s *KvrocksServer) Close() {
}
func StartServer(t testing.TB, configs map[string]string) *KvrocksServer {
- b := os.Getenv("KVROCKS_BIN_PATH")
+ b := *binPath
require.NotEmpty(t, b, "please set the environment variable `KVROCKS_BIN_PATH`")
Review Comment:
this error message maybe outdated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #939: refactor: go cases with var flags
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #939:
URL: https://github.com/apache/incubator-kvrocks/pull/939#issuecomment-1265272777
@PragmaTwice updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #939: refactor: go cases with var flags
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #939:
URL: https://github.com/apache/incubator-kvrocks/pull/939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org