[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2799: Adding support for setting multiple properties at once atomically

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2799:
URL: https://github.com/apache/accumulo/pull/2799#discussion_r929359750


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1017,6 +1019,30 @@ public void setProperty(final String tableName, final String property, final Str
     }
   }
 
+  @Override
+  public void modifyProperties(String tableName, final Consumer<Map<String,String>> mapMutator)
+      throws AccumuloException, AccumuloSecurityException, IllegalArgumentException,
+      ConcurrentModificationException {
+    EXISTING_TABLE_NAME.validate(tableName);
+    checkArgument(mapMutator != null, "mapMutator is null");
+
+    final Map<String,String> properties = ThriftClientTypes.CLIENT.execute(context,

Review Comment:
   The previous ticket [included the idea of throwing ConcurrentModificationException](https://github.com/apache/accumulo/pull/2717#issuecomment-1133596040) when the server detected that the properties changed. That would require the version information suggested in #2821 be incorporated into these changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org