You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/07/06 15:53:54 UTC
[GitHub] [openwhisk-runtime-python] sciabarracom opened a new pull request #110: Support python39
sciabarracom opened a new pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110
- implemented support for python 3.9
- renamed actionloop to action fixes #107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarra commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r667334440
##########
File path: core/python3AiActionLoop/requirements.txt
##########
@@ -30,13 +30,15 @@ numpy == 1.18.1
scikit-learn == 0.22.1
scipy == 1.4.1
pandas == 1.0.1
+spacy == 2.2.4
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarracom commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r665452353
##########
File path: core/python3ActionLoop/requirements.txt
##########
@@ -0,0 +1,28 @@
+# default available packages for python3action
Review comment:
do you want the same? should not be updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarracom closed pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarracom closed pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarracom commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r665437901
##########
File path: core/python39ActionLoop/Dockerfile
##########
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# build go proxy from source
+FROM golang:1.15 AS builder_source
+ARG GO_PROXY_GITHUB_USER=nimbella-corp
+ARG GO_PROXY_GITHUB_BRANCH=dev
+RUN git clone --branch ${GO_PROXY_GITHUB_BRANCH} \
+ https://github.com/${GO_PROXY_GITHUB_USER}/openwhisk-runtime-go /src ;\
+ cd /src ; env GO111MODULE=on CGO_ENABLED=0 go build main/proxy.go && \
+ mv proxy /bin/proxy
+
+# or build it from a release
+FROM golang:1.15 AS builder_release
+ARG GO_PROXY_RELEASE_VERSION=1.15@1.17.0
+RUN curl -sL \
+ https://github.com/apache/openwhisk-runtime-go/archive/{$GO_PROXY_RELEASE_VERSION}.tar.gz\
+ | tar xzf -\
+ && cd openwhisk-runtime-go-*/main\
+ && GO111MODULE=on go build -o /bin/proxy
+
+FROM python:3.9-buster
+
+# select the builder to use
+ARG GO_PROXY_BUILD_FROM=source
+
+# Install common modules for python
+COPY requirements.txt requirements.txt
+RUN pip install --no-cache-dir -r requirements.txt
+
+# install nim
+RUN curl https://apigcp.nimbella.io/downloads/nim/nim-install-linux.sh | bash
Review comment:
Ops!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarra commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r667334521
##########
File path: tests/src/test/scala/runtime/actionContainers/Python39ctionLoopContainerTests.scala
##########
@@ -24,12 +24,12 @@ import spray.json._
import DefaultJsonProtocol._
@RunWith(classOf[JUnitRunner])
-class Python3AiActionLoopContainerTests
+class Python39ActionLoopContainerTests
Review comment:
cleaned all the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarra commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r667334433
##########
File path: core/python3AiActionLoop/requirements.txt
##########
@@ -30,13 +30,15 @@ numpy == 1.18.1
scikit-learn == 0.22.1
scipy == 1.4.1
pandas == 1.0.1
+spacy == 2.2.4
# packages for image processing
Pillow == 7.0.0
# Etc
pymongo == 3.10.1
redis == 3.4.1
+google-cloud-storage == 1.28.1
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarracom commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r667892150
##########
File path: tests/src/test/scala/runtime/actionContainers/Python39Tests.scala
##########
@@ -1,6 +1,3 @@
-#!/usr/bin/env python
Review comment:
I removed this file it is no more possible to "generate" an invalid main... the compilation build the virtual env fails
##########
File path: tests/src/test/scala/runtime/actionContainers/Python39Tests.scala
##########
@@ -1,6 +1,3 @@
-#!/usr/bin/env python
Review comment:
I "constructed" an invalid main removing one file with zip now. All the tests has been refactored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] rabbah commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r664728841
##########
File path: core/python39ActionLoop/Dockerfile
##########
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# build go proxy from source
+FROM golang:1.15 AS builder_source
+ARG GO_PROXY_GITHUB_USER=nimbella-corp
+ARG GO_PROXY_GITHUB_BRANCH=dev
Review comment:
also change the default branch.
```suggestion
ARG GO_PROXY_GITHUB_BRANCH=master
```
##########
File path: core/python39ActionLoop/Dockerfile
##########
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# build go proxy from source
+FROM golang:1.15 AS builder_source
+ARG GO_PROXY_GITHUB_USER=nimbella-corp
+ARG GO_PROXY_GITHUB_BRANCH=dev
+RUN git clone --branch ${GO_PROXY_GITHUB_BRANCH} \
+ https://github.com/${GO_PROXY_GITHUB_USER}/openwhisk-runtime-go /src ;\
+ cd /src ; env GO111MODULE=on CGO_ENABLED=0 go build main/proxy.go && \
+ mv proxy /bin/proxy
+
+# or build it from a release
+FROM golang:1.15 AS builder_release
+ARG GO_PROXY_RELEASE_VERSION=1.15@1.17.0
+RUN curl -sL \
+ https://github.com/apache/openwhisk-runtime-go/archive/{$GO_PROXY_RELEASE_VERSION}.tar.gz\
+ | tar xzf -\
+ && cd openwhisk-runtime-go-*/main\
+ && GO111MODULE=on go build -o /bin/proxy
+
+FROM python:3.9-buster
+
+# select the builder to use
+ARG GO_PROXY_BUILD_FROM=source
+
+# Install common modules for python
+COPY requirements.txt requirements.txt
+RUN pip install --no-cache-dir -r requirements.txt
+
+# install nim
+RUN curl https://apigcp.nimbella.io/downloads/nim/nim-install-linux.sh | bash
Review comment:
remove.
##########
File path: core/python39ActionLoop/Dockerfile
##########
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# build go proxy from source
+FROM golang:1.15 AS builder_source
+ARG GO_PROXY_GITHUB_USER=nimbella-corp
Review comment:
this should be apache.
```suggestion
ARG GO_PROXY_GITHUB_USER=apache
```
##########
File path: core/python3AiActionLoop/requirements.txt
##########
@@ -30,13 +30,15 @@ numpy == 1.18.1
scikit-learn == 0.22.1
scipy == 1.4.1
pandas == 1.0.1
+spacy == 2.2.4
# packages for image processing
Pillow == 7.0.0
# Etc
pymongo == 3.10.1
redis == 3.4.1
+google-cloud-storage == 1.28.1
Review comment:
remove
##########
File path: core/python3AiActionLoop/Dockerfile
##########
@@ -37,7 +37,7 @@ RUN curl -sL \
FROM tensorflow/tensorflow:1.15.2-py3-jupyter
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=release
+ARG GO_PROXY_BUILD_FROM=source
Review comment:
revert
##########
File path: core/python3ActionLoop/requirements.txt
##########
@@ -0,0 +1,28 @@
+# default available packages for python3action
Review comment:
synchronize with python 3.9 file.
##########
File path: core/python3ActionLoop/Dockerfile
##########
@@ -36,20 +36,11 @@ RUN curl -sL \
FROM python:3.7-buster
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=release
+ARG GO_PROXY_BUILD_FROM=source
Review comment:
revert.
##########
File path: core/python3AiActionLoop/requirements.txt
##########
@@ -30,13 +30,15 @@ numpy == 1.18.1
scikit-learn == 0.22.1
scipy == 1.4.1
pandas == 1.0.1
+spacy == 2.2.4
Review comment:
remove?
##########
File path: settings.gradle
##########
@@ -17,8 +17,10 @@
include 'tests'
-include 'core:python3ActionLoop'
+include 'core:python2ActionLoop'
Review comment:
you added python 2 back. remove it.
##########
File path: core/python39ActionLoop/requirements.txt
##########
@@ -0,0 +1,25 @@
+# default available packages for python3action
Review comment:
This list should be no more than https://github.com/apache/openwhisk-runtime-python/blob/0e9b0ea53bb32911eccba0bdc2a748c9e7153080/core/python3ActionLoop/Dockerfile#L42-L52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarracom commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r665586907
##########
File path: core/python3ActionLoop/requirements.txt
##########
@@ -0,0 +1,28 @@
+# default available packages for python3action
Review comment:
ok syncrhonized but I had to update the versions otherwise they do not work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] rabbah commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r665870981
##########
File path: tests/src/test/scala/runtime/actionContainers/Python39ctionLoopContainerTests.scala
##########
@@ -24,12 +24,12 @@ import spray.json._
import DefaultJsonProtocol._
@RunWith(classOf[JUnitRunner])
-class Python3AiActionLoopContainerTests
+class Python39ActionLoopContainerTests
Review comment:
shouldn't this be a copy? you are removing the ai tests?
##########
File path: .travis.yml
##########
@@ -39,13 +39,13 @@ script:
- "./tools/travis/build.sh && ./tools/travis/test.sh"
deploy:
- provider: script
- script: "./tools/travis/publish.sh openwhisk ${TRAVIS_TAG%@*} ${TRAVIS_TAG##*@}"
+ script: "./tools/travis/publish.sh openwhisk ${TRAVIS_TAG%@*} ${TRAVIS_TAG##*@}" && && ./tools/travis/publish.sh openwhisk 39 nightly"
on:
tags: true
all_branches: true
repo: apache/openwhisk-runtime-python
- provider: script
- script: "./tools/travis/publish.sh openwhisk 3 nightly && ./tools/travis/publish.sh openwhisk 3-ai nightly"
+ script: "./tools/travis/publish.sh openwhisk 3 nightly && ./tools/travis/publish.sh openwhisk 3-ai nightly" && ./tools/travis/publish.sh nimbella 39 ${TRAVIS_TAG}"
Review comment:
```suggestion
script: "./tools/travis/publish.sh openwhisk 3 nightly && ./tools/travis/publish.sh openwhisk 3-ai nightly" && ./tools/travis/publish.sh openwhisk 39 ${TRAVIS_TAG}"
```
##########
File path: core/python39ActionLoop/Dockerfile
##########
@@ -0,0 +1,62 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# build go proxy from source
+FROM golang:1.15 AS builder_source
+ARG GO_PROXY_GITHUB_USER=apache
+ARG GO_PROXY_GITHUB_BRANCH=master
+RUN git clone --branch ${GO_PROXY_GITHUB_BRANCH} \
+ https://github.com/${GO_PROXY_GITHUB_USER}/openwhisk-runtime-go /src ;\
+ cd /src ; env GO111MODULE=on CGO_ENABLED=0 go build main/proxy.go && \
+ mv proxy /bin/proxy
+
+# or build it from a release
+FROM golang:1.15 AS builder_release
+ARG GO_PROXY_RELEASE_VERSION=1.15@1.17.0
+RUN curl -sL \
+ https://github.com/apache/openwhisk-runtime-go/archive/{$GO_PROXY_RELEASE_VERSION}.tar.gz\
+ | tar xzf -\
+ && cd openwhisk-runtime-go-*/main\
+ && GO111MODULE=on go build -o /bin/proxy
+
+FROM python:3.9-buster
+
+# select the builder to use
+ARG GO_PROXY_BUILD_FROM=source
Review comment:
```suggestion
ARG GO_PROXY_BUILD_FROM=release
```
to match the others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] rabbah commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r667498099
##########
File path: tests/src/test/scala/runtime/actionContainers/Python39Tests.scala
##########
@@ -1,6 +1,3 @@
-#!/usr/bin/env python
Review comment:
how did git get so confused about this file - this is not a moved file :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarracom commented on pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#issuecomment-881813187
plase merge #111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarracom commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r665442466
##########
File path: core/python39ActionLoop/requirements.txt
##########
@@ -0,0 +1,25 @@
+# default available packages for python3action
Review comment:
ok reverted to the default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] rabbah commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r666942761
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
Review comment:
```suggestion
The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux AMD64 environment. It will be executed at start time to use your extra libraries.
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
Review comment:
```suggestion
Virtuale envs are usually built listing your dependencies in a `requirements.txt`.
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
+
+You have to create a folder `myaction` with at least two files:
+
+```
+__main__.py
+requirements.txt
+```
+
+Then zip your action and send to OpenWhisk, the requirements will be solved for you at init time, creating a suitable virtualenv
+
+However, since resolving requirements involves downloading software from Internet, it can be pretty slow.
+
+Very likely your action using a `requirements.txt` will timeout at init time.
+
+So there is a way to precompile the action and resolve requirements at build time.
+
Review comment:
```suggestion
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
+
+You have to create a folder `myaction` with at least two files:
+
+```
+__main__.py
+requirements.txt
+```
+
+Then zip your action and send to OpenWhisk, the requirements will be solved for you at init time, creating a suitable virtualenv
+
+However, since resolving requirements involves downloading software from Internet, it can be pretty slow.
+
+Very likely your action using a `requirements.txt` will timeout at init time.
Review comment:
```suggestion
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
+
+You have to create a folder `myaction` with at least two files:
+
+```
+__main__.py
+requirements.txt
+```
+
+Then zip your action and send to OpenWhisk, the requirements will be solved for you at init time, creating a suitable virtualenv
Review comment:
```suggestion
Then zip your action and deploy to OpenWhisk, the requirements will be installed for you at init time, creating a suitable virtualenv.
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
+
+You have to create a folder `myaction` with at least two files:
+
+```
+__main__.py
+requirements.txt
+```
+
+Then zip your action and send to OpenWhisk, the requirements will be solved for you at init time, creating a suitable virtualenv
+
+However, since resolving requirements involves downloading software from Internet, it can be pretty slow.
+
+Very likely your action using a `requirements.txt` will timeout at init time.
+
Review comment:
```suggestion
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
Review comment:
```suggestion
If you have an action that requires addition libraries, you can just include `requirements.txt`.
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
Review comment:
```suggestion
If you need more libraries for your Python action, you can include a virtualenv in the zip file of the action.
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
+
+You have to create a folder `myaction` with at least two files:
+
+```
+__main__.py
+requirements.txt
+```
+
+Then zip your action and send to OpenWhisk, the requirements will be solved for you at init time, creating a suitable virtualenv
+
+However, since resolving requirements involves downloading software from Internet, it can be pretty slow.
+
+Very likely your action using a `requirements.txt` will timeout at init time.
+
+So there is a way to precompile the action and resolve requirements at build time.
Review comment:
```suggestion
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
+
+You have to create a folder `myaction` with at least two files:
+
+```
+__main__.py
+requirements.txt
+```
+
+Then zip your action and send to OpenWhisk, the requirements will be solved for you at init time, creating a suitable virtualenv
+
+However, since resolving requirements involves downloading software from Internet, it can be pretty slow.
+
+Very likely your action using a `requirements.txt` will timeout at init time.
+
+So there is a way to precompile the action and resolve requirements at build time.
+
+## Precompilation of a virtualenv
+
+The action containers can actually generate a virtualenv for you, provided you have a requirements.txt.
+
+
+If you have an action in the format described before (with a `requirements.txt`) you can build the zip file with the included files with:
+
+```
+zip -j -r myaction | docker run -i action-python-v3.7 -compile main >myaction.zip
+```
+
+(you can use also `v3.9` and `v3.6-ai`)
+
+The resulting action includes a virtualenv already built for you and that is fast to deploy and start as all the dependencies are already solved.
Review comment:
```suggestion
The resulting action includes a virtualenv already built for you and that is fast to deploy and start as all the dependencies are already resolved. Note that there is a limit on the size of the zip file and this approach will not work for installing large libraries like Pandas or Numpy, instead use the provide "v.3.6-ai" runtime instead which provides these libraries already for you.
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
+
+You have to create a folder `myaction` with at least two files:
+
+```
+__main__.py
+requirements.txt
+```
+
+Then zip your action and send to OpenWhisk, the requirements will be solved for you at init time, creating a suitable virtualenv
+
+However, since resolving requirements involves downloading software from Internet, it can be pretty slow.
+
+Very likely your action using a `requirements.txt` will timeout at init time.
+
+So there is a way to precompile the action and resolve requirements at build time.
+
+## Precompilation of a virtualenv
+
+The action containers can actually generate a virtualenv for you, provided you have a requirements.txt.
+
+
+If you have an action in the format described before (with a `requirements.txt`) you can build the zip file with the included files with:
+
+```
+zip -j -r myaction | docker run -i action-python-v3.7 -compile main >myaction.zip
+```
+
+(you can use also `v3.9` and `v3.6-ai`)
Review comment:
```suggestion
You may use `v3.9` or `v3.6-ai` as well according to your Python version needs.
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
+
+You have to create a folder `myaction` with at least two files:
Review comment:
```suggestion
You have to create a folder `myaction` with at least two files:
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
+
+You have to create a folder `myaction` with at least two files:
+
+```
+__main__.py
+requirements.txt
+```
+
+Then zip your action and send to OpenWhisk, the requirements will be solved for you at init time, creating a suitable virtualenv
+
+However, since resolving requirements involves downloading software from Internet, it can be pretty slow.
Review comment:
```suggestion
Keep in mind that resolving requirements involves downloading and install software, so your action timeout limit may need to be adjusted accordingly. Instead, you should consider using precompilation to resolve the requirements at build time.
```
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
+
+If you have an action that requires addition libraries, you can just include `requirements.txt`
+
+You have to create a folder `myaction` with at least two files:
+
+```
+__main__.py
+requirements.txt
+```
+
+Then zip your action and send to OpenWhisk, the requirements will be solved for you at init time, creating a suitable virtualenv
+
+However, since resolving requirements involves downloading software from Internet, it can be pretty slow.
+
+Very likely your action using a `requirements.txt` will timeout at init time.
+
+So there is a way to precompile the action and resolve requirements at build time.
+
+## Precompilation of a virtualenv
+
+The action containers can actually generate a virtualenv for you, provided you have a requirements.txt.
+
+
+If you have an action in the format described before (with a `requirements.txt`) you can build the zip file with the included files with:
Review comment:
```suggestion
If you have an action in the format described before (with a `requirements.txt`) you can build the zip file with the included files with:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarracom commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r665451209
##########
File path: settings.gradle
##########
@@ -17,8 +17,10 @@
include 'tests'
-include 'core:python3ActionLoop'
+include 'core:python2ActionLoop'
Review comment:
damn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarra commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r667334485
##########
File path: core/python3ActionLoop/Dockerfile
##########
@@ -36,20 +36,11 @@ RUN curl -sL \
FROM python:3.7-buster
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=release
+ARG GO_PROXY_BUILD_FROM=source
Review comment:
again I need the master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] sciabarra commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
sciabarra commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r667334404
##########
File path: core/python3AiActionLoop/Dockerfile
##########
@@ -37,7 +37,7 @@ RUN curl -sL \
FROM tensorflow/tensorflow:1.15.2-py3-jupyter
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=release
+ARG GO_PROXY_BUILD_FROM=source
Review comment:
Here I need a PR that is not yet avalable as a release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] rabbah commented on a change in pull request #110: Support python39
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #110:
URL: https://github.com/apache/openwhisk-runtime-python/pull/110#discussion_r666942932
##########
File path: README.md
##########
@@ -400,14 +399,57 @@ Gradle allows you to selectively run tests. For example, the following
command runs tests which match the given pattern and excludes all
others.
```
-./gradlew :tests:test --tests *ActionLoopContainerTests*
+./gradlew :tests:test --tests Python*Tests
```
## Python 3 AI Runtime
-This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiActionLoop).
+This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running machine learning and deep learning inferences. [Read more about this runtime here](./core/python3AiAction).
## Import Project into IntelliJ
Follow these steps to import the project into your IntelliJ IDE.
- Import project as gradle project.
- Make sure the working directory is root of the project/repo.
+
+# Using extra libraries
+
+If you need more libraries for your python action, you can include a virtualenv in the zip file of the action.
+
+The requirement is that the zip file must have a subfolder named `virtualenv` with a script `virtualenv\bin\activate_this.py` working in an Linux Amd64 environment. It will be executed at start time to use your extra libraries.
+
+## Using requirements.txt
+
+Virtuale envs are usually built listing your dependencies in a `requirements.txt`
Review comment:
```suggestion
Virtual envs are usually built listing your dependencies in a `requirements.txt`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org