You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2023/03/21 07:10:42 UTC
[GitHub] [incubator-opendal] suyanhanx opened a new pull request, #1711: chore(bindings/nodejs): bump @napi-rs/cli to 2.15.0
suyanhanx opened a new pull request, #1711:
URL: https://github.com/apache/incubator-opendal/pull/1711
After upgrading to this version, the license header can be automatically added without the need for manual maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on pull request #1711: chore(bindings/nodejs): bump @napi-rs/cli to 2.15.0
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #1711:
URL: https://github.com/apache/incubator-opendal/pull/1711#issuecomment-1477375856
> I don't understand. It's more complicated than before...
Currently, using a patch to handle this is not ideal.
Additionally, the license header in the submitted `generated.js` file is manually maintained by me.
Once upstream support is improved, we should switch to using a script for uniform processing. At that time, the patch can be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #1711: chore(bindings/nodejs): bump @napi-rs/cli to 2.15.0
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1711:
URL: https://github.com/apache/incubator-opendal/pull/1711#issuecomment-1477371102
I don't understand. It's more complicated than before...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo closed pull request #1711: chore(bindings/nodejs): bump @napi-rs/cli to 2.15.0
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed pull request #1711: chore(bindings/nodejs): bump @napi-rs/cli to 2.15.0
URL: https://github.com/apache/incubator-opendal/pull/1711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on pull request #1711: chore(bindings/nodejs): bump @napi-rs/cli to 2.15.0
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #1711:
URL: https://github.com/apache/incubator-opendal/pull/1711#issuecomment-1477399535
> Let's use old tech like `cat` or `sed`.
This actually depends on the user's environment. However, if it is executing a JS script, it will be able to run successfully because `Node.js` is definitely installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #1711: chore(bindings/nodejs): bump @napi-rs/cli to 2.15.0
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1711:
URL: https://github.com/apache/incubator-opendal/pull/1711#issuecomment-1477380138
Let's use old tech like `cat` or `sed`. We don't need to depend on napi to do this anymore. I didn't satisfied with the existing solution.
I will close this PR now. Thanks for the effort and communication with upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #1711: chore(bindings/nodejs): bump @napi-rs/cli to 2.15.0
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1711:
URL: https://github.com/apache/incubator-opendal/pull/1711#issuecomment-1477403208
I will propose a change later today for reviewing 🤩
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org