You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/21 06:42:22 UTC
[GitHub] [hive] jshmchenxi commented on a change in pull request #1611: HIVE-12371 Adding a timeout connection parameter for JDBC
jshmchenxi commented on a change in pull request #1611:
URL: https://github.com/apache/hive/pull/1611#discussion_r546534493
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -1002,11 +1002,19 @@ private String getSessionValue(String varName, String varDefault) {
return varValue;
}
- // copy loginTimeout from driver manager. Thrift timeout needs to be in millis
+ // use socketTimeout from jdbc connection url. Thrift timeout needs to be in millis
private void setupLoginTimeout() {
- long timeOut = TimeUnit.SECONDS.toMillis(DriverManager.getLoginTimeout());
+ String socketTimeoutStr = sessConfMap.getOrDefault(JdbcConnectionParams.SOCKET_TIMEOUT, "0");
+ long timeOut = 0;
Review comment:
This issue describes the problem: [HIVE-22196](https://issues.apache.org/jira/browse/HIVE-22196) : Socket timeouts happen when other drivers set DriverManager.loginTimeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org