You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "scholarsmate (via GitHub)" <gi...@apache.org> on 2023/09/22 14:34:04 UTC
[GitHub] [daffodil-vscode] scholarsmate opened a new pull request, #856: update nightly CI to test under node 16 and 18
scholarsmate opened a new pull request, #856:
URL: https://github.com/apache/daffodil-vscode/pull/856
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on pull request #856: update nightly CI to test under node 16 and 18
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on PR #856:
URL: https://github.com/apache/daffodil-vscode/pull/856#issuecomment-1734104081
This looks good but I'm also dealing with build issues on my Linux box on main. The difference between the CI jobs and my OS is that I'm running a derivation of Ubuntu 22.04 but the CI is _only_ running 20.04.
Is there any reason to not be running `-latest` versions? My build failure on the `main` branch seems like this should be something tested and pretty critical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #856: update nightly CI to test under node 16 and 18
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #856:
URL: https://github.com/apache/daffodil-vscode/pull/856#issuecomment-1734106534
@stricklandrbls, great point. We can cover the earliest _and_ latest versions of the OSes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #856: update nightly CI to test under node 16 and 18
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #856:
URL: https://github.com/apache/daffodil-vscode/pull/856#issuecomment-1731614727
It's not the same as the existing actions as the nightlies test the latest stable and insider's versions of VS Code, not just a pinned version (1.67.2).
The nightly workflow has a workflow_dispatch trigger so I was able to run it manually over at the CTC-OSS fork: https://github.com/ctc-oss/daffodil-vscode/actions/runs/6275784426/job/17044528000.
<img width="1730" alt="Screenshot 2023-09-22 at 11 22 47 AM" src="https://github.com/apache/daffodil-vscode/assets/2205472/d6ffd2c6-9417-4a2e-a668-d7f04b424e92">
All the MacOS and Linux tests pass, and of course Windows is having some strange problem across all the Windows tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate merged pull request #856: update nightly CI to test under node 16 and 18
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate merged PR #856:
URL: https://github.com/apache/daffodil-vscode/pull/856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #856: update nightly CI to test under node 16 and 18
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #856:
URL: https://github.com/apache/daffodil-vscode/pull/856#issuecomment-1731557076
What do nightlies do differently than PR and Push checks? It looks basically the same as the existing actions. Can we just remove this since ever PR and merge is already checked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org