[jira] [Closed] (SUREFIRE-597) Surefire report creation fails on processing absent optional JUnit xml attributes

["Tibor Digana (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SUREFIRE-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tibor Digana closed SUREFIRE-597.
---------------------------------
    Resolution: Fixed

Introduced unit test Surefire597Test in maven-surefire-report-plugin module.

> Surefire report creation fails on processing absent optional JUnit xml attributes
> ---------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-597
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-597
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Surefire Report Plugin
>    Affects Versions: 2.4.3
>            Reporter: Maksym Symonov
>            Assignee: Tibor Digana
>            Priority: Minor
>             Fix For: 2.19
>
>
> Surefire report creation fails when JUnit XML source for report doesn't contain optional attributes. I use Clojure with junit xml output, it produces xml with <failure> subnode of <testcase>. It has no "message" and "type" attributes specified for it. But has error message as nested text. Plugin processes this xml and fails with NullPointerException SurefireReportGenerator.java:676, as i see in the code, it's not possible for it to have <failure> node without "type" attribute. Maybe it would be better to add null checking at that method?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)