You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Alex Eagle (JIRA)" <ji...@apache.org> on 2009/10/24 21:52:59 UTC

[jira] Created: (BUILDR-332) New maven location for scalatest 1.0 not configurable

New maven location for scalatest 1.0 not configurable
-----------------------------------------------------

                 Key: BUILDR-332
                 URL: https://issues.apache.org/jira/browse/BUILDR-332
             Project: Buildr
          Issue Type: Bug
          Components: Test frameworks
    Affects Versions: 1.3.5
         Environment: All
            Reporter: Alex Eagle


At revision 829438, vim +63 lib/buildr/scala/tests.rb

["org.scala-tools.testing:scalatest:jar:#{version}"] + Check.dependencies +

The new version 1.0 of scalatest has been released, and the maven package has changed. Now it is here:
http://www.scala-tools.org/repo-releases/org/scalatest/scalatest/1.0/

Need some conditional here to look in the right package depending on the requested version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (BUILDR-332) New maven location for scalatest 1.0 not configurable

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert reassigned BUILDR-332:
------------------------------------

    Assignee: Alex Boisvert

> New maven location for scalatest 1.0 not configurable
> -----------------------------------------------------
>
>                 Key: BUILDR-332
>                 URL: https://issues.apache.org/jira/browse/BUILDR-332
>             Project: Buildr
>          Issue Type: Bug
>          Components: Test frameworks
>    Affects Versions: 1.3.5
>         Environment: All
>            Reporter: Alex Eagle
>            Assignee: Alex Boisvert
>         Attachments: BUILDR-332.patch
>
>
> At revision 829438, vim +63 lib/buildr/scala/tests.rb
> ["org.scala-tools.testing:scalatest:jar:#{version}"] + Check.dependencies +
> The new version 1.0 of scalatest has been released, and the maven package has changed. Now it is here:
> http://www.scala-tools.org/repo-releases/org/scalatest/scalatest/1.0/
> Need some conditional here to look in the right package depending on the requested version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-332) New maven location for scalatest 1.0 not configurable

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775189#action_12775189 ] 

Alex Boisvert commented on BUILDR-332:
--------------------------------------

Oh and to be clear:  My plan is to officially support ScalaTest 1.0 in Buildr 1.4.0 and provide backward compatibility for it in Buildr versions beyond that.  I have no intentions of supporting ScalaTest versions prior to 1.0 at this point since these were alpha/beta versions.

> New maven location for scalatest 1.0 not configurable
> -----------------------------------------------------
>
>                 Key: BUILDR-332
>                 URL: https://issues.apache.org/jira/browse/BUILDR-332
>             Project: Buildr
>          Issue Type: Bug
>          Components: Test frameworks
>    Affects Versions: 1.3.5
>         Environment: All
>            Reporter: Alex Eagle
>            Assignee: Alex Boisvert
>         Attachments: BUILDR-332.patch
>
>
> At revision 829438, vim +63 lib/buildr/scala/tests.rb
> ["org.scala-tools.testing:scalatest:jar:#{version}"] + Check.dependencies +
> The new version 1.0 of scalatest has been released, and the maven package has changed. Now it is here:
> http://www.scala-tools.org/repo-releases/org/scalatest/scalatest/1.0/
> Need some conditional here to look in the right package depending on the requested version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-332) New maven location for scalatest 1.0 not configurable

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775188#action_12775188 ] 

Alex Boisvert commented on BUILDR-332:
--------------------------------------

By the way, in Buildr 1.3.5, this issue can be fixed by monkey-patching the ScalaTest class in your Buildfile:

module Buildr::Scala
  class ScalaTest
    class << self
      def dependencies
        ["org.scalatest:scalatest:jar:1.0"] + Check.dependencies +
          JMock.dependencies + JUnit.dependencies
      end
    end
  end
end

We've now upgraded to ScalaTest 1.0 in trunk so Buidlr 1.4.0 will use it by default.

*BUT* even with this fix (your patch or the change in trunk) there's another issue about supporting both ScalaTest 0.9.5 and 1.0 which is that the integration code requires some additional tweaking for ScalaTest 1.0.  I've also fixed this in Buildr trunk (a simple change of regex) but I'm hoping to improve the code so that we don't have to parse the ScalaTest report output to determine the pass/fail/ignored tests.

> New maven location for scalatest 1.0 not configurable
> -----------------------------------------------------
>
>                 Key: BUILDR-332
>                 URL: https://issues.apache.org/jira/browse/BUILDR-332
>             Project: Buildr
>          Issue Type: Bug
>          Components: Test frameworks
>    Affects Versions: 1.3.5
>         Environment: All
>            Reporter: Alex Eagle
>            Assignee: Alex Boisvert
>         Attachments: BUILDR-332.patch
>
>
> At revision 829438, vim +63 lib/buildr/scala/tests.rb
> ["org.scala-tools.testing:scalatest:jar:#{version}"] + Check.dependencies +
> The new version 1.0 of scalatest has been released, and the maven package has changed. Now it is here:
> http://www.scala-tools.org/repo-releases/org/scalatest/scalatest/1.0/
> Need some conditional here to look in the right package depending on the requested version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-332) New maven location for scalatest 1.0 not configurable

Posted by "Alex Eagle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Eagle updated BUILDR-332:
------------------------------

    Attachment: BUILDR-332.patch

Patch for this issue.

Tested by running a build with
Buildr.settings.build['scala.test'] = "0.9.5"
and
Buildr.settings.build['scala.test'] = "1.0"

> New maven location for scalatest 1.0 not configurable
> -----------------------------------------------------
>
>                 Key: BUILDR-332
>                 URL: https://issues.apache.org/jira/browse/BUILDR-332
>             Project: Buildr
>          Issue Type: Bug
>          Components: Test frameworks
>    Affects Versions: 1.3.5
>         Environment: All
>            Reporter: Alex Eagle
>         Attachments: BUILDR-332.patch
>
>
> At revision 829438, vim +63 lib/buildr/scala/tests.rb
> ["org.scala-tools.testing:scalatest:jar:#{version}"] + Check.dependencies +
> The new version 1.0 of scalatest has been released, and the maven package has changed. Now it is here:
> http://www.scala-tools.org/repo-releases/org/scalatest/scalatest/1.0/
> Need some conditional here to look in the right package depending on the requested version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (BUILDR-332) New maven location for scalatest 1.0 not configurable

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert resolved BUILDR-332.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4

I'm marking as fixed since this issue doesn't occur in trunk anymore.  My recommendation for you at this point is to use buildr-trunk until we release 1.4.0.

> New maven location for scalatest 1.0 not configurable
> -----------------------------------------------------
>
>                 Key: BUILDR-332
>                 URL: https://issues.apache.org/jira/browse/BUILDR-332
>             Project: Buildr
>          Issue Type: Bug
>          Components: Test frameworks
>    Affects Versions: 1.3.5
>         Environment: All
>            Reporter: Alex Eagle
>            Assignee: Alex Boisvert
>             Fix For: 1.4
>
>         Attachments: BUILDR-332.patch
>
>
> At revision 829438, vim +63 lib/buildr/scala/tests.rb
> ["org.scala-tools.testing:scalatest:jar:#{version}"] + Check.dependencies +
> The new version 1.0 of scalatest has been released, and the maven package has changed. Now it is here:
> http://www.scala-tools.org/repo-releases/org/scalatest/scalatest/1.0/
> Need some conditional here to look in the right package depending on the requested version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.