Re: [PR] KAFKA-14884: Include check transaction is still ongoing right before append (take 2) [kafka]

["ijuma (via GitHub)" <gi...@apache.org>]

ijuma commented on code in PR #13787:
URL: https://github.com/apache/kafka/pull/13787#discussion_r1361468169


##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1279,7 +1283,7 @@ class Partition(val topicPartition: TopicPartition,
   }
 
   def appendRecordsToLeader(records: MemoryRecords, origin: AppendOrigin, requiredAcks: Int,
-                            requestLocal: RequestLocal): LogAppendInfo = {
+                            requestLocal: RequestLocal, verificationGuard: Object = null): LogAppendInfo = {

Review Comment:
   Hmm, why are we passing `Object` here and various other places? This is generally an anti-pattern since _anything_ can be passed even though it may not be valid. You should create a type for the verification guard.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org