You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2008/09/11 00:32:44 UTC

[jira] Created: (SOLR-767) logged "hits" should be num matching docs, not num returned

logged "hits" should be num matching docs, not num returned
-----------------------------------------------------------

                 Key: SOLR-767
                 URL: https://issues.apache.org/jira/browse/SOLR-767
             Project: Solr
          Issue Type: Bug
    Affects Versions: 1.3
            Reporter: Yonik Seeley
            Priority: Minor
             Fix For: 1.3




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-767) logged "hits" should be num matching docs, not num returned

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved SOLR-767.
-------------------------------

    Resolution: Fixed

committed.

> logged "hits" should be num matching docs, not num returned
> -----------------------------------------------------------
>
>                 Key: SOLR-767
>                 URL: https://issues.apache.org/jira/browse/SOLR-767
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Yonik Seeley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-767.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-767) logged "hits" should be num matching docs, not num returned

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-767:
------------------------------

    Attachment: SOLR-767.patch

Trivial one line patch (also attached)

-    rsp.getToLog().add("hits", rb.getResults().docList.size());
+    rsp.getToLog().add("hits", rb.getResults().docList.matches());

If there are no objections, this should go in 1.3 and I'll commit shortly.


> logged "hits" should be num matching docs, not num returned
> -----------------------------------------------------------
>
>                 Key: SOLR-767
>                 URL: https://issues.apache.org/jira/browse/SOLR-767
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Yonik Seeley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-767.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-767) logged "hits" should be num matching docs, not num returned

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630289#action_12630289 ] 

Yonik Seeley commented on SOLR-767:
-----------------------------------

bq. An alternative would be to add a "matches" or "totalMatches" log entry and keep hits. 

But the number of documents returned is redundant data if you have the number of matches, so it doesn't seem like we want that extra stuff in the log for every query.

> logged "hits" should be num matching docs, not num returned
> -----------------------------------------------------------
>
>                 Key: SOLR-767
>                 URL: https://issues.apache.org/jira/browse/SOLR-767
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Yonik Seeley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-767.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-767) logged "hits" should be num matching docs, not num returned

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630308#action_12630308 ] 

Grant Ingersoll commented on SOLR-767:
--------------------------------------

OK.

> logged "hits" should be num matching docs, not num returned
> -----------------------------------------------------------
>
>                 Key: SOLR-767
>                 URL: https://issues.apache.org/jira/browse/SOLR-767
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Yonik Seeley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-767.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.