You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Henryk Konsek (JIRA)" <ji...@apache.org> on 2012/06/19 09:04:43 UTC
[jira] [Created] (CAMEL-5379) Introduce EmptyAsyncCallback
Henryk Konsek created CAMEL-5379:
------------------------------------
Summary: Introduce EmptyAsyncCallback
Key: CAMEL-5379
URL: https://issues.apache.org/jira/browse/CAMEL-5379
Project: Camel
Issue Type: Improvement
Components: camel-core
Reporter: Henryk Konsek
Assignee: Henryk Konsek
Fix For: 2.10.0
What about replacing anonymous inner noop AsyncCallback with EmptyAsyncCallback? Just to make a codebase a little bit nicer.
// Bad
Object value = invocation.proceed(new AsyncCallback() {
public void done(boolean doneSync) {
// nnop
}
}, sync);
// Good
Object value = invocation.proceed(new EmptyAsyncCallback(), sync);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5379) Introduce EmptyAsyncCallback
Posted by "Henryk Konsek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henryk Konsek updated CAMEL-5379:
---------------------------------
Priority: Trivial (was: Major)
> Introduce EmptyAsyncCallback
> ----------------------------
>
> Key: CAMEL-5379
> URL: https://issues.apache.org/jira/browse/CAMEL-5379
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Henryk Konsek
> Assignee: Henryk Konsek
> Priority: Trivial
> Fix For: 2.10.0
>
> Attachments: camel-emptyAsyncCallBack.patch
>
>
> What about replacing anonymous inner noop AsyncCallback with EmptyAsyncCallback? Just to make a codebase a little bit nicer.
> // Bad
> Object value = invocation.proceed(new AsyncCallback() {
> public void done(boolean doneSync) {
> // nnop
> }
> }, sync);
> // Good
> Object value = invocation.proceed(new EmptyAsyncCallback(), sync);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5379) Introduce EmptyAsyncCallback
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-5379:
-------------------------------
Fix Version/s: (was: 2.10.0)
2.11
> Introduce EmptyAsyncCallback
> ----------------------------
>
> Key: CAMEL-5379
> URL: https://issues.apache.org/jira/browse/CAMEL-5379
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Henryk Konsek
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 2.11
>
> Attachments: camel-5379.patch, camel-emptyAsyncCallBack.patch
>
>
> What about replacing anonymous inner noop AsyncCallback with EmptyAsyncCallback? Just to make a codebase a little bit nicer.
> // Bad
> Object value = invocation.proceed(new AsyncCallback() {
> public void done(boolean doneSync) {
> // nnop
> }
> }, sync);
> // Good
> Object value = invocation.proceed(new EmptyAsyncCallback(), sync);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-5379) Introduce EmptyAsyncCallback
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-5379:
----------------------------------
Assignee: Claus Ibsen (was: Henryk Konsek)
> Introduce EmptyAsyncCallback
> ----------------------------
>
> Key: CAMEL-5379
> URL: https://issues.apache.org/jira/browse/CAMEL-5379
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Henryk Konsek
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 2.10.0
>
> Attachments: camel-emptyAsyncCallBack.patch
>
>
> What about replacing anonymous inner noop AsyncCallback with EmptyAsyncCallback? Just to make a codebase a little bit nicer.
> // Bad
> Object value = invocation.proceed(new AsyncCallback() {
> public void done(boolean doneSync) {
> // nnop
> }
> }, sync);
> // Good
> Object value = invocation.proceed(new EmptyAsyncCallback(), sync);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5379) Introduce EmptyAsyncCallback
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-5379:
-------------------------------
Attachment: camel-5379.patch
Polished patch with CS and final class
> Introduce EmptyAsyncCallback
> ----------------------------
>
> Key: CAMEL-5379
> URL: https://issues.apache.org/jira/browse/CAMEL-5379
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Henryk Konsek
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 2.10.0
>
> Attachments: camel-5379.patch, camel-emptyAsyncCallBack.patch
>
>
> What about replacing anonymous inner noop AsyncCallback with EmptyAsyncCallback? Just to make a codebase a little bit nicer.
> // Bad
> Object value = invocation.proceed(new AsyncCallback() {
> public void done(boolean doneSync) {
> // nnop
> }
> }, sync);
> // Good
> Object value = invocation.proceed(new EmptyAsyncCallback(), sync);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5379) Introduce EmptyAsyncCallback
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396839#comment-13396839 ]
Claus Ibsen commented on CAMEL-5379:
------------------------------------
Oh Hadrian started the release process. I will hold of and commit this later.
> Introduce EmptyAsyncCallback
> ----------------------------
>
> Key: CAMEL-5379
> URL: https://issues.apache.org/jira/browse/CAMEL-5379
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Henryk Konsek
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 2.10.0
>
> Attachments: camel-5379.patch, camel-emptyAsyncCallBack.patch
>
>
> What about replacing anonymous inner noop AsyncCallback with EmptyAsyncCallback? Just to make a codebase a little bit nicer.
> // Bad
> Object value = invocation.proceed(new AsyncCallback() {
> public void done(boolean doneSync) {
> // nnop
> }
> }, sync);
> // Good
> Object value = invocation.proceed(new EmptyAsyncCallback(), sync);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5379) Introduce EmptyAsyncCallback
Posted by "Henryk Konsek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410295#comment-13410295 ]
Henryk Konsek commented on CAMEL-5379:
--------------------------------------
I feel rejected :P But I can understand your approach. :)
> Introduce EmptyAsyncCallback
> ----------------------------
>
> Key: CAMEL-5379
> URL: https://issues.apache.org/jira/browse/CAMEL-5379
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Henryk Konsek
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 2.11
>
> Attachments: camel-5379.patch, camel-emptyAsyncCallBack.patch
>
>
> What about replacing anonymous inner noop AsyncCallback with EmptyAsyncCallback? Just to make a codebase a little bit nicer.
> // Bad
> Object value = invocation.proceed(new AsyncCallback() {
> public void done(boolean doneSync) {
> // nnop
> }
> }, sync);
> // Good
> Object value = invocation.proceed(new EmptyAsyncCallback(), sync);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-5379) Introduce EmptyAsyncCallback
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-5379.
--------------------------------
Resolution: Won't Fix
Lets keep the codebase as is, keeping the 2.x API stable.
> Introduce EmptyAsyncCallback
> ----------------------------
>
> Key: CAMEL-5379
> URL: https://issues.apache.org/jira/browse/CAMEL-5379
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Henryk Konsek
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 2.11
>
> Attachments: camel-5379.patch, camel-emptyAsyncCallBack.patch
>
>
> What about replacing anonymous inner noop AsyncCallback with EmptyAsyncCallback? Just to make a codebase a little bit nicer.
> // Bad
> Object value = invocation.proceed(new AsyncCallback() {
> public void done(boolean doneSync) {
> // nnop
> }
> }, sync);
> // Good
> Object value = invocation.proceed(new EmptyAsyncCallback(), sync);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5379) Introduce EmptyAsyncCallback
Posted by "Henryk Konsek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henryk Konsek updated CAMEL-5379:
---------------------------------
Attachment: camel-emptyAsyncCallBack.patch
EmptyAsyncCallback patch attached.
> Introduce EmptyAsyncCallback
> ----------------------------
>
> Key: CAMEL-5379
> URL: https://issues.apache.org/jira/browse/CAMEL-5379
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Henryk Konsek
> Assignee: Henryk Konsek
> Fix For: 2.10.0
>
> Attachments: camel-emptyAsyncCallBack.patch
>
>
> What about replacing anonymous inner noop AsyncCallback with EmptyAsyncCallback? Just to make a codebase a little bit nicer.
> // Bad
> Object value = invocation.proceed(new AsyncCallback() {
> public void done(boolean doneSync) {
> // nnop
> }
> }, sync);
> // Good
> Object value = invocation.proceed(new EmptyAsyncCallback(), sync);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira