You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2017/05/16 22:26:22 UTC

[kudu-CR] KUDU-2016: Fix Java client's ColumnSchema.getDefaultValue()

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6903

to look at the new patch set (#2).

Change subject: KUDU-2016: Fix Java client's ColumnSchema.getDefaultValue()
......................................................................

KUDU-2016: Fix Java client's ColumnSchema.getDefaultValue()

The Java client was setting the default value to the read default
value instead of the write default value, when deserializing a
ColumnSchemaPB. The write default value is what should be exposed.

Change-Id: Ifacb860a34cb860ff9e03020f2d5683c9ba6fa46
---
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
2 files changed, 31 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/6903/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifacb860a34cb860ff9e03020f2d5683c9ba6fa46
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>