[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #863: [HUDI-227] : DeltaStreamer Improvements : Commit empty input batch with progressing checkpoints and allow users to override configs through properties

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #863: [HUDI-227] : DeltaStreamer Improvements : Commit empty input batch with progressing checkpoints and allow users to override configs through properties
URL: https://github.com/apache/incubator-hudi/pull/863#discussion_r319283147
 
 

 ##########
 File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
 ##########
 @@ -299,11 +302,17 @@ private void refreshTimeline() throws IOException {
       schemaProvider = dataAndCheckpoint.getSchemaProvider();
     }
 
-    if ((!avroRDDOptional.isPresent()) || (avroRDDOptional.get().isEmpty())) {
-      log.info("No new data, nothing to commit.. ");
+    if (Objects.equals(checkpointStr, resumeCheckpointStr.orElse(null))) {
+      log.info("No progress in source consumption. Old checkeckpoint=(" + resumeCheckpointStr
 
 Review comment:
   can we keep "No new data, source checkpoint has not changed. Nothing to commit." as the message. typo in "Old checkpoint". 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services