You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2024/08/23 08:44:36 UTC
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21717
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Column id is an internal concept, this patch
adds a new flag --show_column_id to indicate
whether to show it when using 'kudu table describe'.
It's helpful to compare whether two tables'
schema are competely the same with considering
the internal column id as well.
Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
---
M src/kudu/client/schema.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
3 files changed, 45 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/21717/1
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/448/
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 23 Aug 2024 08:44:45 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 27 Aug 2024 12:17:18 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 1:
> Patch Set 1: Verified-1
>
> Build Failed
>
> http://jenkins.kudu.apache.org/job/pre_commit/448/ : FAILURE
Test failures(RELEASE mode) seem related.
/home/jenkins-slave/workspace/build_and_test/src/kudu/tools/kudu-admin-test.cc:2315: Failure
Value of: stdout
Expected: has substring "(\n 10:foo INT32 NOT NULL,\n 11:bar INT32 NOT NULL,\n PRIMARY KEY (foo)\n)\n"
Actual: "TABLE TestAnotherTable (\n 0:foo INT32 NOT NULL,\n 1:bar INT32 NOT NULL,\n PRIMARY KEY (foo)\n)\nRANGE (foo) (\n PARTITION UNBOUNDED\n)\nOWNER slave\nREPLICAS 3\nCOMMENT \n"
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 23 Aug 2024 12:14:05 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/472/
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 06 Sep 2024 18:19:56 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21717
to look at the new patch set (#2).
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Column id is an internal concept, this patch
adds a new flag --show_column_id to indicate
whether to show it when using 'kudu table describe'.
It's helpful to compare whether two tables'
schema are competely the same with considering
the internal column id as well.
Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
---
M src/kudu/client/schema.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
3 files changed, 82 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/21717/2
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 13 Sep 2024 03:10:47 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2:
Overall looks good to me! Thank you!
There were some weird logs in the build end regarding the workspace. Re-triggered the Jenkins verification just to make sure. Afterwards I can submit it.
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 06 Sep 2024 18:21:34 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 13 Sep 2024 07:02:15 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/476/
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 09 Sep 2024 10:50:28 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/458/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2024 09:59:46 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/472/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 06 Sep 2024 19:08:57 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2:
> Patch Set 2:
>
> Overall looks good to me! Thank you!
> There were some weird logs in the build end regarding the workspace. Re-triggered the Jenkins verification just to make sure. Afterwards I can submit it.
> Thanks!
Please check the latest Jenkins logs, thanks!
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 13 Sep 2024 07:02:46 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Column id is an internal concept, this patch
adds a new flag --show_column_id to indicate
whether to show it when using 'kudu table describe'.
It's helpful to compare whether two tables'
schema are competely the same with considering
the internal column id as well.
Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Reviewed-on: http://gerrit.cloudera.org:8080/21717
Reviewed-by: Yifan Zhang <ch...@163.com>
Reviewed-by: Wang Xixu <14...@qq.com>
Tested-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M src/kudu/client/schema.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
3 files changed, 82 insertions(+), 37 deletions(-)
Approvals:
Yifan Zhang: Looks good to me, approved
Wang Xixu: Looks good to me, but someone else must approve
Yingchun Lai: Verified
Marton Greber: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/448/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 23 Aug 2024 09:29:28 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/476/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 09 Sep 2024 11:36:35 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2: Code-Review+2
Yepp the java CI error is know, unrelated to this patch.
LGTM, thanks for the patch!
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 13 Sep 2024 12:40:55 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3606 [tools] Show column ids when using 'kudu table describe'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21717 )
Change subject: KUDU-3606 [tools] Show column ids when using 'kudu table describe'
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/458/
--
To view, visit http://gerrit.cloudera.org:8080/21717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b28bd8f879bb6cace1683bc366c72772caebdc
Gerrit-Change-Number: 21717
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2024 09:14:16 +0000
Gerrit-HasComments: No