You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/29 09:48:02 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request, #16616: [Java Client] Send CloseConsumer on client timeout
michaeljmarshall opened a new pull request, #16616:
URL: https://github.com/apache/pulsar/pull/16616
Related: https://github.com/apache/pulsar/pull/13161 and https://github.com/apache/pulsar/pull/12948
### Motivation
The current Java Client consumer code does not clean up a pending consumer on the server when the client's timeout expires. This creates problems when the client tries to recreate the consumer with a `Subscribe` command. In this case, we see warnings like the following:
>2022-07-13T23:51:53,323+0000 [pulsar-io-12-6] WARN org.apache.pulsar.broker.service.ServerCnx - [/10.249.212.73:41536][persistent://public/default/test][test] Consumer with id is already present on the connection, consumerId=66
### Modifications
* Send `CloseConsumer` command when the `Subscribe` command times out from the client perspective.
### Verifying this change
This change includes new tests.
### Does this pull request potentially affect one of the following parts:
This change introduces new recommendation for the Pulsar Protocol, but it does not make any breaking changes.
Note also that the C++ client already follows this behavior.
### Documentation
- [x] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #16616: [Java Client] Send CloseConsumer on client timeout
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #16616:
URL: https://github.com/apache/pulsar/pull/16616#issuecomment-1185452755
> This creates problems when the client tries to recreate the consumer with a `Subscribe` command. In this case, we see warnings like the following:
>
> > 2022-07-13T23:51:53,323+0000 [pulsar-io-12-6] WARN org.apache.pulsar.broker.service.ServerCnx - [/10.249.212.73:41536][persistent://public/default/test][test] Consumer with id is already present on the connection, consumerId=66
@michaeljmarshall were there other issues or was it only about a warning in the logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli closed pull request #16616: [Java Client] Send CloseConsumer on client timeout
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #16616: [Java Client] Send CloseConsumer on client timeout
URL: https://github.com/apache/pulsar/pull/16616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #16616: [Java Client] Send CloseConsumer on client timeout
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #16616:
URL: https://github.com/apache/pulsar/pull/16616#issuecomment-1185451673
Just wondering if the underlying problem could be related to #14970 ?
There is also #15051 which made changes in this area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #16616: [Java Client] Send CloseConsumer on client timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #16616:
URL: https://github.com/apache/pulsar/pull/16616#issuecomment-1199084177
closed/reopened to trigger CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #16616: [Java Client] Send CloseConsumer on client timeout
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #16616:
URL: https://github.com/apache/pulsar/pull/16616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16616: [Java Client] Send CloseConsumer on client timeout
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16616:
URL: https://github.com/apache/pulsar/pull/16616#issuecomment-1186555225
> @michaeljmarshall were there other issues or was it only about a warning in the logs?
+1, and a question, what if the close consumer command times out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org