You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/08/29 10:52:29 UTC
[PR] test(desktop): story-cover toast error and edge states [maka]
liuxiaocs7 opened a new pull request, #4167:
URL: https://github.com/apache/maka/pull/4167
## Summary
Third surface under #3944 (one surface per PR): extend `Primitives/Toast` with the failure and edge states that never show up in normal use, so the Storybook gate and the #3893 a11y audit have real targets. Every story drives the production `ToastProvider` API — no fabricated UI.
- **ErrorWithDiagnostics** — an error toast carrying the provider's diagnostics action, plus the branch where opening diagnostics *itself* fails and the provider raises its own failure toast. A failed save, an offline sync, and an unauthorised request all land on this one error affordance, so it stands in for the trio rather than inventing three screens; `play` exercises the action-failure path a bare `error` variant never reaches.
- **DestructiveConfirm** — an irreversible action's confirmation: the confirm button wears the destructive variant and initial focus rests on cancel, so the dangerous path is never the default.
- **LongContent** — very long title and body; the card must wrap legibly instead of clipping text or shoving the layout off-screen.
- **ManyStacked** — eight notifications at once, exercising the stack's density and whatever cap or scroll the layer applies.
Refs #3944, #3893
## Verification
- `apps/desktop` `typecheck:stories` + `@maka/ui` `typecheck` pass; Biome lint and `git diff --check` clean.
- Storybook build + render smoke: **200 stories**, all green, no runtime/console/page errors, per-story AX-tree audit clean. The four new ids: `primitives-toast--error-with-diagnostics`, `--destructive-confirm`, `--long-content`, `--many-stacked`.
- `play` runs under the smoke (it waits for `storyFinished`): clicking the error toast's diagnostics action raises the provider's failure toast; the destructive confirm opens with the destructive action present and cancel focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(desktop): story-cover toast error and edge states [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4167:
URL: https://github.com/apache/maka/pull/4167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(desktop): story-cover toast error and edge states [maka]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #4167:
URL: https://github.com/apache/maka/pull/4167#issuecomment-5464715027
Added a **Visual evidence** section to the PR description (screenshots on the fork's release assets): the diagnostics failure sequence (error toast + follow-up failure toast), the destructive confirm with focus on Cancel, long content, and the eight stacked notifications — normal/light and narrow/dark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(desktop): story-cover toast error and edge states [maka]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #4167:
URL: https://github.com/apache/maka/pull/4167#issuecomment-5464661393
Thanks for the review, and for confirming the four states are clean at the code level.
Confirming the points you raised:
- **Destructive treatment**: the confirmation goes through the production `ConfirmDialog`, which sets `actionVariant={destructive ? 'destructive' : 'primary'}` on the Astryx `AlertDialog`, and initial focus rests on Cancel (asserted in the play). So it uses Astryx's own destructive treatment, not a bespoke one.
- **Boundaries**: agreed and noted — the diagnostics story uses an intentionally-rejected callback (not the real Electron diagnostics bridge), and the Storybook AX smoke is not the full #3893 Desktop accessibility journey. Neither is claimed as more than it is.
Long-text clipping and stack legibility are visual properties I can't assert in the render smoke, so they're for the screenshots.
On that: I'm in a headless/CI environment and can't attach screenshots to the PR directly. The four states render deterministically under stable ids (`primitives-toast--error-with-diagnostics` / `--destructive-confirm` / `--long-content` / `--many-stacked`). Happy to host PNGs somewhere if there's a preferred channel, or you can pull the branch and capture the four (including the diagnostics failure sequence and eight stacked toasts in light/dark). No code change in this revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org